xtos: move sof/lib/mailbox.h to application interface #9562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SOF mailbox.h provides an interface to host-DSP mailboxes, which is used widely in SOF IPC and debug code. This interface is OS agnostistic and only relies on platform/lib/mailbox.h to define the mailbox locations, and rtos/cache.h to define portable cache primitives to invalidate/writeback mailbox data before/after use. The amount of RTOS variation does not seem to warrant branching the whole mailbox.h to RTOS layer. Move mailbox.h back to application interface, so the single implementation can be shared. Link: thesofproject#9015 Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
kv2019i
requested review from
LaurentiuM1234,
iuliana-prodan and
marcinszkudlinski
39 tasks
tmleman
approved these changes
Oct 11, 2024
dbaluta
approved these changes
Oct 11, 2024
LaurentiuM1234
approved these changes
Oct 14, 2024
|
SOFCI TEST |
lgirdwood
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SOF mailbox.h provides an interface to host-DSP mailboxes, which is used widely in SOF IPC and debug code.
This interface is OS agnostistic and only relies on platform/lib/mailbox.h to define the mailbox locations, and rtos/cache.h to define portable cache primitives to invalidate/writeback mailbox data before/after use.
The amount of RTOS variation does not seem to warrant branching the whole mailbox.h to RTOS layer. Move mailbox.h back to application interface, so the single implementation can be shared.
Link: #9015