Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for running SOF on imx95 #9512

Merged
merged 9 commits into from
Oct 4, 2024

Conversation

LaurentiuM1234
Copy link
Contributor

@LaurentiuM1234 LaurentiuM1234 commented Sep 25, 2024

Related issue: #9485.
Currently waiting for Zephyr dependencies to be merged.
Waiting on last Zephyr dependency: zephyrproject-rtos/zephyr#79192

Comment on lines +11 to +15
#define CLK_MAX_CPU_HZ 800000000
#define CPU_DEFAULT_IDX 0
#define NUM_CPU_FREQ 1
#define NUM_CLOCKS 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LaurentiuM1234 I think @kv2019i got rid of a lot of these last week since they should come from Zephyr - can you check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm...double-checked and couldn't find anything else to drop w/o breaking the build... @kv2019i anything obvious that I'm missing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I'm probably wrong, probably in process of being removed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack @LaurentiuM1234 @lgirdwood platform clk.h is still needed. We have a Zephyr version of clk.h that still depends on it. OTOH, I did a quick look and it seems this could be cleaned up further as well as the usage of clk.h is not much in app code -> #9541

@dbaluta
Copy link
Collaborator

dbaluta commented Sep 30, 2024

This looks good to me. Lets wait for Zephyr side to be merged and clarify @lgirdwood comment. Then it is good to merge.

@LaurentiuM1234 LaurentiuM1234 changed the title Add support for running SOF on imx95 [DNM]: add support for running SOF on imx95 Sep 30, 2024
@LaurentiuM1234
Copy link
Contributor Author

Tagged with [DNM] and removed from draft for initial comments.

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +11 to +15
#define CLK_MAX_CPU_HZ 800000000
#define CPU_DEFAULT_IDX 0
#define NUM_CPU_FREQ 1
#define NUM_CLOCKS 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I'm probably wrong, probably in process of being removed.

Add platform files for NXP's imx95.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
Add configuration option for the new imx95 platform.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
The imx95 platform uses MU version 2. As such, select
the appropriate version.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
Include required sources for the imx95 platform.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
Add entries for imx95's EDMA2 and HOST_DMA.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
This module is required by the Cortex-M architecture so
update west.yml to pull in this module as well.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
Add topology for the imx95 platform.
The pipeline is:

   HOST ----> VOLUME (optional, may be passthrough)  ----> DAI

Signed-off-by: Laurentiu Mihalcea <[email protected]>
Add DTS and configuration overlay for the imx95 platform.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
This means modifying 'xtensa-build-zephyr.py' to allow
building the new platform and adding a new toml file for
the platform.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
@LaurentiuM1234 LaurentiuM1234 changed the title [DNM]: add support for running SOF on imx95 add support for running SOF on imx95 Oct 3, 2024
@LaurentiuM1234
Copy link
Contributor Author

Rebased and dropped DNM tag. Should be good to go.

@dbaluta
Copy link
Collaborator

dbaluta commented Oct 3, 2024

Good to go. Checkpatch.pl warnings are non-issues.

@lgirdwood
Copy link
Member

@wszypelt @lrudyX good to merge, is this platform not tested by Intel CI.

@lrudyX
Copy link

lrudyX commented Oct 4, 2024

@wszypelt @lrudyX good to merge, is this platform not tested by Intel CI.

Tests are completed with green :)

@dbaluta dbaluta merged commit b107e40 into thesofproject:main Oct 4, 2024
44 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants