Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Topology2: Add include of mtl.conf for LNL HDA generic #8889

Merged

Conversation

singalsu
Copy link
Collaborator

This quick fix avoids build of NHLT blob for the default (TGL) for LNL HDA generic platform.

The DMIC part of NHLT from TGL is not suitable for LNL, while a blob for MTL can be used. A proper lnl.conf will be added later.

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still draft ?
@ranj063 good for you ?

@singalsu singalsu marked this pull request as ready for review March 1, 2024 15:08
@singalsu singalsu requested review from ranj063 and jsarha as code owners March 1, 2024 15:08
@singalsu
Copy link
Collaborator Author

singalsu commented Mar 1, 2024

Still draft ?

Oops forgot, now ready!

This quick fix avoids build of NHLT blob for the default (TGL)
for LNL HDA generic platform.

The DMIC part of NHLT from TGL is not suitable for LNL, while a
blob for MTL can be used. A proper lnl.conf will be added later.

Signed-off-by: Seppo Ingalsuo <[email protected]>
@singalsu singalsu force-pushed the tplg2_hda_generic_lnl_platform_fix branch from dc2b2fa to 1238147 Compare April 11, 2024 10:39
@singalsu singalsu requested a review from kv2019i April 11, 2024 10:39
@singalsu
Copy link
Collaborator Author

No changes to patch, rebase and push again to restart CI.

Note: DMIC and SSP blobs from topology can't work in LNL without this fix.

@lgirdwood lgirdwood merged commit 660e278 into thesofproject:main Apr 15, 2024
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants