Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE][IPC4] src/audio/base_fw should use abstractions to get hw/board specific data #8391

Closed
kv2019i opened this issue Oct 25, 2023 · 4 comments
Closed

[FEATURE][IPC4] src/audio/base_fw should use abstractions to get hw/board specific data #8391

kv2019i opened this issue Oct 25, 2023 · 4 comments
Assignees
@kv2019i
Labels
enhancement New feature or request IPC4 Issues observed with IPC4 (same IPC as Windows)
Milestone
v2.10

Comments

@kv2019i
Copy link
Collaborator

kv2019i commented Oct 25, 2023

Is your feature request related to a problem? Please describe.
The IPC4_HW_CONFIG_GET and IPC4_FW_CONFIG handlers are implemented in common code in src/audio/base_fw.c but currently have some hardcode values for specific Intel targets.

Describe the solution you'd like
This code should be abstracted to get pure hardware properties from Zephyr DTS, SOF application level data either from Kconfig or from platform.h interfaces (see #7248), so that generic code can be reused across targets.

Describe alternatives you've considered

Additional context
@kv2019i kv2019i added the enhancement New feature or request label Oct 25, 2023
This was referenced Oct 25, 2023
Open
Closed
@lgirdwood lgirdwood added this to the v2.9 milestone Oct 31, 2023
@lgirdwood
Copy link
Member

Lets pencil in for v2.9 so we can all align. @dbaluta fyi.

@lgirdwood
Copy link
Member

adding @iuliana-prodan too

@kv2019i kv2019i self-assigned this Dec 18, 2023
@kv2019i kv2019i modified the milestones: v2.9, v2.10 Feb 23, 2024
@kv2019i
Copy link
Collaborator Author

kv2019i commented Feb 23, 2024

One week from branch point and this has not been started, moving to v2.10.

This was referenced Apr 3, 2024
Merged
Merged
@kv2019i kv2019i added the IPC4 Issues observed with IPC4 (same IPC as Windows) label Apr 9, 2024
@kv2019i kv2019i mentioned this issue Apr 18, 2024
Merged
@kv2019i
Copy link
Collaborator Author

kv2019i commented Apr 24, 2024

With #9060 merged, we can close this.

@kv2019i kv2019i closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kv2019i kv2019i

Labels
enhancement New feature or request IPC4 Issues observed with IPC4 (same IPC as Windows)
Projects
None yet
Milestone
v2.10
Development

No branches or pull requests
2 participants
@lgirdwood @kv2019i