Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

determine best framework for errors and validation #7

Open
benguhin opened this issue Aug 7, 2020 · 7 comments
Open

determine best framework for errors and validation #7

benguhin opened this issue Aug 7, 2020 · 7 comments
Assignees
Labels

Comments

@benguhin
Copy link
Contributor

benguhin commented Aug 7, 2020

breaking out from #5

@theresaanna
Copy link

Research so far:

I am looking at three different libraries.
https://parsleyjs.org/
https://validatejs.org/
https://formvalidation.io/

Parsley looks like a simpler basic implementation. Validate looks most flexible. FormValidation has some nice built in validators and plugin system. Each are well-documented. Parsley looks to, based on examples, require extra work to do certain things, like immediate feedback to the user if there's a validation error. You do need to click the submit button before receiving feedback, by default, in Parsley, and I don't see examples that do it automatically. @benguhin do you have any thoughts about whether there's an optimal path here? Clicking submit vs. real-time feedback? Here are the example forms: https://parsleyjs.org/doc/examples/simple.html https://validatejs.org/examples.html https://formvalidation.io/guide/examples

FormValidation gives a lot of great examples, which I think would make implementation easiest while giving a lot of power. I am leaning in that direction but would love thoughts!

@khwilson
Copy link
Contributor

Not my call on design, but I'm a fan of realtime feedback and client side validation whenever possible. :-)

@benguhin
Copy link
Contributor Author

Yeah I think real-time client-side feedback would be great. Any reason to not use FormValidation? (I will go ahead and say that the license cost is not a blocker)

@theresaanna
Copy link

@benguhin No, I think FormValidation might be the best bet. Do you know what we'd have to do to get a license?

@theresaanna
Copy link

theresaanna commented Aug 17, 2020

I'm going to close out this issue because we've determined the best framework. Now we need to figure out how to purchase and implement, which is a separate issue.

ETA: I don't think I'm able to close the issue.

@theresaanna
Copy link

Further work needed: research HTML5 built in form validation with our form and see if it does what is needed. Jumping off point: https://developer.mozilla.org/en-US/docs/Learn/Forms/HTML5_input_types

@theresaanna
Copy link

Note: plan to take on this research Monday-Tuesday 8/24-25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants