-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cwd target doesn't work with ibazel #67
Comments
Ah, that's a bummer. I wasn't able to find a current issue on Bazel's GitHub issues tracker, I'll file one. |
I tried to build a minimal reproduction of I do see that ibazel is leaving dangling processes when run through multitool's cwd target, but it's less clear to me that bazel run is broken? |
When running your provided script I see the same dangling bazel processes -- so it seems like this is really an ibazel bug. |
Interesting, @walkerburgin confirmed they saw a problem but I don't know what Bazel version. Do you have time to make a repro? |
Running latest ibazel directly (no bazel, shell, or multitool involved) also leaves dangling processes on a ctrl+c. |
Yeah it's an ibazel bug, it so happens that calling it through |
A customer pointed out that the pattern documented on the README
https://github.com/theoremlp/rules_multitool?tab=readme-ov-file#running-tools-in-the-current-working-directory
doesn't work correctly with some programs like
ibazel
(bazel-watcher) because zombie processes get left behind.We think this post from @lberki is related https://groups.google.com/g/bazel-discuss/c/I6TWUv8AI5o
I think this can be reproduced by running some server target under
./tools/ibazel //my/server:target
, then when you ctrl-c (SIGINT) you'll still see the server is running.So we changed our
aspect init
aspect-build/aspect-workflows-template#87to still stamp out a script that DOES function correctly:
Personally I think
bazel run
is still just busted in a way rules_multitool shouldn't try to fix.The text was updated successfully, but these errors were encountered: