picturefill subelements of passed element

[awentzonline]

It might be nice to just pass a top-level element to picturefill which would then find subelements to be picturefilled.

[csinchok]

I think that's already supported?

Chris Sinchok
Developer
730 N. Franklin St. #700
Chicago IL 60654
the Onion | "America's Finest News Source"

On Wed, Dec 17, 2014 at 1:48 PM, Adam Wentz [email protected]
wrote:

It might be nice to just pass a top-level element to picturefill which
would then find subelements to be picturefilled.

—
Reply to this email directly or view it on GitHub
#41.

[awentzonline]

I thought it did too, but that clickhole quiz image bug report from today led me to read through image.js a bit more carefully. I believe this line was making it appear to work: https://github.com/theonion/betty-cropper/blob/master/betty/cropper/templates/image.js#L45 Since the front-end js usually selects elements with jquery it would fall through to that case.

[csinchok]

Aw fuck, you're right. That's my bad.

Chris Sinchok
Developer
730 N. Franklin St. #700
Chicago IL 60654
the Onion | "America's Finest News Source"

On Wed, Dec 17, 2014 at 2:38 PM, Adam Wentz [email protected]
wrote:

I thought it did too, but that clickhole quiz image bug report from today
led me to read through image.js a bit more carefully. I believe this line
was making it appear to work:
https://github.com/theonion/betty-cropper/blob/master/betty/cropper/templates/image.js#L45
Since the front-end js usually selects elements with jquery it would fall
through to that case.

—
Reply to this email directly or view it on GitHub
#41 (comment)
.