-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add google cloud datastore Lock implementation #135
base: master
Are you sure you want to change the base?
Conversation
Can index.yaml be moved somewhere else? i.e. test directory? |
yes, certainly |
already move the file to test folder |
Can you also extend the readme? |
btw: Can you please use the use function |
use Lock.use instead of "require"
done |
Is the datastore “testable” via travis or should we skip it in the tests? |
It should be. Might take a deeper look later on today. |
I think so too, but I haven't got lucky with cloud datastore emulator in the past few days |
else it should be skipped here |
Hi, I just added google cloud datastore implementation, I use it on my project
Just thought that you want to include it in your original repo.
Thanks