Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google cloud datastore Lock implementation #135

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

amura2406
Copy link

Hi, I just added google cloud datastore implementation, I use it on my project
Just thought that you want to include it in your original repo.

Thanks

@adrai
Copy link
Contributor

adrai commented Oct 29, 2018

Can index.yaml be moved somewhere else? i.e. test directory?

@amura2406
Copy link
Author

yes, certainly

@amura2406
Copy link
Author

already move the file to test folder

@adrai
Copy link
Contributor

adrai commented Oct 30, 2018

Can you also extend the readme?

@adrai
Copy link
Contributor

adrai commented Oct 30, 2018

btw: Can you please use the use function Lock.use instead of require (like the other db implementations)?

use Lock.use instead of "require"
@amura2406
Copy link
Author

done

@adrai
Copy link
Contributor

adrai commented Oct 31, 2018

Is the datastore “testable” via travis or should we skip it in the tests?

@nanov
Copy link
Contributor

nanov commented Oct 31, 2018

It should be. Might take a deeper look later on today.

@amura2406
Copy link
Author

I think so too, but I haven't got lucky with cloud datastore emulator in the past few days

@adrai
Copy link
Contributor

adrai commented Nov 12, 2018

else it should be skipped here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants