Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle the JSon libraries with the plug-in. #7

Open
thegreystone opened this issue Jun 19, 2018 · 5 comments
Open

Bundle the JSon libraries with the plug-in. #7

thegreystone opened this issue Jun 19, 2018 · 5 comments
Labels
enhancement New feature or request hackergarten help wanted Extra attention is needed

Comments

@thegreystone
Copy link
Owner

It would be nice to be able to work with the Flame Graph view, even when there is no direct connection to https://cdnjs.cloudflare.com. That said, it may be an issue getting at the resources as they are in a jar, and need to be referenced from the HTML. One solution would be to just write the JavaScript libraries to a well known location (a well known folder in temp for example). That however may be considered a security risk.

This bug is about figuring out how to best accomplish bundling the JSon libraries with the plug-in. ;)

@thegreystone thegreystone added help wanted Extra attention is needed enhancement New feature or request labels Jun 19, 2018
@nbogojevic
Copy link
Contributor

One way to work around this is to launch local server that listens on random ephemeral port and serves all this content from class path resources.
All javascript libraries would be bundled inside (maybe along page.html file). Browser in view would then target the server url instead of using setText.

@thegreystone
Copy link
Owner Author

Yep, that is one alternative. It would be interesting to see if such a solution would have different performance characteristics.

@nbogojevic
Copy link
Contributor

Did some test around this approach. Subjective feeling is that actually seems faster to render when content is served via server, there are also some advantages as javascript code can be well cached by browser, but I have to test it little bit more.

The approach also allows to work around #4 - in that one I think the issue is that eclipse uses internet explorer to render web pages on all versions of Windows. By using embeded server, I can open it in external browser (Chrome, Firefox, Edge) and it renders correctly.

@thegreystone
Copy link
Owner Author

Oh gods. There should be a bug open on Eclipse for embedding Edge instead of Internet Explorer when available. ;)

@thegreystone
Copy link
Owner Author

I opened one:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=538991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hackergarten help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants