-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with git sv tag
#127
Comments
Cant reproduce: ❯ git tag
v1.0.0
❯ ~/Devel/golang/projects/git-sv/dist/git-sv rn
## v1.0.1 (2024-10-30)
### Maintenance
- add git-sv templates (15b815c)
- update READMEs (bef84fd)
- migrate git provider (8970647)
- remove release-helper workflow (c149e49)
- add license (218b8e7)
- update pre-commit hooks (6f243a4)
- update renovate prefix (2f1c59d)
### CI
- also run lint on tag events (03152b8)
- create tag with v prefix (d3c7266)
- add changelog and release workflows (79cdcdc)
❯ ~/Devel/golang/projects/git-sv/dist/git-sv tag --local
v1.0.1
❯ git tag
v1.0.0
v1.0.1 |
Skipping
So from what I can see it works as intended up to the tag push asking for the auth data. |
Thanks for checking! I'll investigate again, couldn't get any return after multiple minutes on multiple tries. |
Have you found something? |
Not yet, still same behavior with 1.0.6 (just tried it again). If the next version has more debug/trace logs that would show parts of the process, I could narrow it down better and infer where it is stuck (running with |
Update: I see this issue on all repos I've tried so far (n=4). Not sure what the possible issues source could be here, maybe it is even OS-specific? I can try on a Linux server these days to maybe narrow this down in more detail. |
Thanks can try it also on my work mac. |
Works for me on my mac as well:
So I have absolutely no clue what the issue could be. |
Strange. Last idea would be the shell. But I already tried with fish and bash. Super strange. Would be interesting to find out. I guess I'll check out the code and do some debug runs. |
Im curious was well. If I can support you somehow, let me know. |
While debugging I found that it hangs at this line Line 164 in bf49aa6
when jumping in, it hangs at func (c *Cmd) CombinedOutput() ([]byte, error) {
if c.Stdout != nil {
return nil, errors.New("exec: Stdout already set")
}
if c.Stderr != nil {
return nil, errors.New("exec: Stderr already set")
}
var b bytes.Buffer
c.Stdout = &b
c.Stderr = &b
err := c.Run()
return b.Bytes(), err
} go 1.23.4 via homebrew I then installed go via https://go.dev/doc/install assuming it is a homebrew issue but see the same behavior with the non-homebrew install. Weird. |
You could check a few things:
|
No.
Yes. That's how I've done it all the time before trying
No hooks. Given that it hands when executing If you search for |
I would still like to find out, especially as I tried really hard to reproduce it with various mac VMs in different versions without success. |
Yeah but |
Can you test a build with CGO_ENABLED=0 GOOS=darwin GOARCH=amd64 go build -v -tags 'netgo,osusergo' -ldflags '-extldflags "-static" -s -w' -o dist/git-sv ./cmd/git-sv |
Same issue.
Yes that one works 🤔️ |
Ok lets try another approach:
|
This outputs so much (incl. processes from other programs) that I can't see anything useful or paste the output here.
is a bit reduced but I still don't know what to look out for. Just an excerpt here (the head looks a bit different) (running in vscode terminal)
|
This should definitely not contain anything other than what is involved in executing git-sv. Can you share the full output, via DM is also fine if you don't want to share it here. |
What Im really wondering about is how the heck is Electron involved here? The last col is the process-name and seeing Electron here is kinda weird (and I dont see it in a full trace on my system) |
git sv tag
just hangs for all my repos. Even withgit sv --log-level debug tg
I don't get any output.v1.0.5
git sv rn
andgit sv cgl
work fine. Example repoThe text was updated successfully, but these errors were encountered: