From 52e071f4fe15745232ee5da131faa496e76f5aac Mon Sep 17 00:00:00 2001 From: Ron Lavi <1ronlavi@gmail.com> Date: Tue, 16 Jan 2024 10:45:15 +0000 Subject: [PATCH] Fixes #37013 - address review comments - Remove layout from context as it's not being used - Adjust the setting description as it doesn't require page reload anymore --- app/registries/foreman/settings/general.rb | 2 +- webpack/assets/javascripts/react_app/Root/ReactApp.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/registries/foreman/settings/general.rb b/app/registries/foreman/settings/general.rb index bf62e7eed3ee..5910b4d906b4 100644 --- a/app/registries/foreman/settings/general.rb +++ b/app/registries/foreman/settings/general.rb @@ -53,7 +53,7 @@ full_name: N_('Show Experimental Labs')) setting('new_hosts_page', type: :boolean, - description: N_("Whether or not to show the new overview page for All Hosts (requires reload of page)"), + description: N_("Whether or not to show the new overview page for All Hosts"), default: false, full_name: N_('Show New Host Overview Page')) setting('display_fqdn_for_hosts', diff --git a/webpack/assets/javascripts/react_app/Root/ReactApp.js b/webpack/assets/javascripts/react_app/Root/ReactApp.js index fe186aff9972..4af38571a2a3 100644 --- a/webpack/assets/javascripts/react_app/Root/ReactApp.js +++ b/webpack/assets/javascripts/react_app/Root/ReactApp.js @@ -13,7 +13,7 @@ import ErrorBoundary from '../components/common/ErrorBoundary'; import ConfirmModal from '../components/ConfirmModal'; const ReactApp = ({ layout, metadata, toasts }) => { - const [context, setContext] = useState({ layout, metadata }); + const [context, setContext] = useState({ metadata }); const contextData = { context, setContext }; const ForemanContext = getForemanContext(contextData);