Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting arbitrary environment variables in foreman_plugin #44

Closed
laugmanuel opened this issue Feb 21, 2024 · 3 comments · Fixed by #45
Closed

Support setting arbitrary environment variables in foreman_plugin #44

laugmanuel opened this issue Feb 21, 2024 · 3 comments · Fixed by #45

Comments

@laugmanuel
Copy link
Member

We should support setting arbitrary environment variables by passing them as an input to the job.
This would allow the caller/user to customize the test behaviour by reading the variables back in code.

See discussion in dm-drogeriemarkt/foreman_wreckingball#113

@laugmanuel
Copy link
Member Author

@ekohl, @evgeni any feedback on the request?

@evgeni
Copy link
Member

evgeni commented Feb 29, 2024

The request is valid, we just didn't have time to think about it further.

@laugmanuel
Copy link
Member Author

@evgeni I've prepared a PR for this feature.
It looks a bit hacky as I didn't find another way of passing information from caller to the reusable workflow. Passing env directly is a limitation stated here: https://docs.github.com/en/actions/using-workflows/reusing-workflows#limitations

@evgeni evgeni closed this as completed in #45 Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants