[removed] redundant Number conversion in watch

thealjey · Dec 31, 2015 · 4299688 · 4299688
1 parent 6da6e97
commit 4299688
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 9 deletions.
diff --git a/docs/quicksearch.html b/docs/quicksearch.html
diff --git a/docs/watch.js.html b/docs/watch.js.html
@@ -99,7 +99,7 @@ <h1 class="page-title">Source: watch.js</h1>
  * watch(join(__dirname, 'src'), 'js', someFunction);
  */
 export function watch(dir: string, type: string, callback: () => void) {
-  const subscription = Number(Date.now()).toString(ALPHANUMERIC_BASE);
+  const subscription = Date.now().toString(ALPHANUMERIC_BASE);
 
   client.capabilityCheck({}, capabilityErr => {
     if (capabilityErr) {

diff --git a/lib/watch.js b/lib/watch.js
@@ -28,7 +28,7 @@ var client = new _fbWatchman.Client(),
  * watch(join(__dirname, 'src'), 'js', someFunction);
  */
 function watch(dir, type, callback) {
-  var subscription = Number(Date.now()).toString(ALPHANUMERIC_BASE);
+  var subscription = Date.now().toString(ALPHANUMERIC_BASE);
 
   client.capabilityCheck({}, function (capabilityErr) {
     if (capabilityErr) {

diff --git a/src/watch.js b/src/watch.js
@@ -23,7 +23,7 @@ const client = new Client(),
  * watch(join(__dirname, 'src'), 'js', someFunction);
  */
 export function watch(dir: string, type: string, callback: () => void) {
-  const subscription = Number(Date.now()).toString(ALPHANUMERIC_BASE);
+  const subscription = Date.now().toString(ALPHANUMERIC_BASE);
 
   client.capabilityCheck({}, capabilityErr => {
     if (capabilityErr) {

diff --git a/test/watch.spec.js b/test/watch.spec.js
@@ -18,21 +18,20 @@ class Client {
 const ALPHANUMERIC_BASE = 36,
     watch = proxyquire('../src/watch', {'fb-watchman': {Client}}).watch;
 
-let callback;
+let callback, toString;
 
 describe('watch', () => {
 
   beforeEach(() => {
     callback = spy();
-    stub(Date, 'now');
-    stub(Number.prototype, 'toString').returns('qwerty');
+    toString = stub().returns('qwerty');
+    stub(Date, 'now').returns({toString});
     stub(console, 'log');
     stub(console, 'error');
   });
 
   afterEach(() => {
     Date.now.restore();
-    Number.prototype.toString.restore();
     console.log.restore();
     console.error.restore();
   });
@@ -48,7 +47,7 @@ describe('watch', () => {
     });
 
     it('calls number toString', () => {
-      expect(Number.prototype.toString).calledWith(ALPHANUMERIC_BASE);
+      expect(toString).calledWith(ALPHANUMERIC_BASE);
     });
 
   });