Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Themes are kind-of way too powerful... #53

Open
andriemc opened this issue May 27, 2023 · 10 comments
Open

[BUG] Themes are kind-of way too powerful... #53

andriemc opened this issue May 27, 2023 · 10 comments
Labels
bug Something isn't working

Comments

@andriemc
Copy link
Contributor

andriemc commented May 27, 2023

Describe the bug
A clear and concise description of what the bug is.
Sooo. I made a theme that makes your acrd.app account unusable if you apply it.

To Reproduce
Steps to reproduce the behavior:

  1. Apply theme, https://acrd.app/themes/hHLzdcJ
  2. See problem.

Screenshots
If applicable, add screenshots to help explain your problem.

On an alt
image

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Brave (Chromium Based)
  • Version: Winter 0.5.0-pre-release

Additional context
Add any other context about the problem here.
No.

@andriemc andriemc added the bug Something isn't working label May 27, 2023
@andriemc
Copy link
Contributor Author

By the way. DO NOT APPLY THIS ON YOUR MAIN ACCOUNT, I REPEAT. DO NOT APPLY THIS ON YOUR MAIN ACCOUNT

@andriemc
Copy link
Contributor Author

andriemc commented May 27, 2023

NOTE: You can fix it by dispatching this in redux devtools for your account. (You must be logged in though.)

{
  type: 'auth/updatedUser',
  payload: {
  	userId: "(your userid)",
        partialUser: {
    	     activeThemeId: "default",
    }
  }
}

or going back in time using redux devtools then changing the theme back to normal.

@theADAMJR
Copy link
Owner

image

@theADAMJR
Copy link
Owner

There could be a keep changes prompt after changing theme, like when you change screen resolution on Windows and it auto reverts after after 15 seconds. It would have inline styles so that * { display: none; } does not break it.

@theADAMJR
Copy link
Owner

Also if themes were saved to localStorage, as opposed to the user, you could simply reset cookies to reverse the changes, after the user wilfully accepts the delete everything on the page theme for whatever reason, rather than needing to a new account because the page doesn't load on that account.

@andriemc
Copy link
Contributor Author

image

what de hailllllllllllllll

@andriemc
Copy link
Contributor Author

Also if themes were saved to localStorage, as opposed to the user, you could simply reset cookies to reverse the changes, after the user wilfully accepts the delete everything on the page theme for whatever reason, rather than needing to a new account because the page doesn't load on that account.

mhm yeah. that'd work better than using saving themes on the server rather then the client.

@andriemc
Copy link
Contributor Author

You should make a official guild as well so people can talk about accord stuff & themes there

@andriemc
Copy link
Contributor Author

RED.

image

@theADAMJR
Copy link
Owner

image
image
Added a built-in pure CSS theme based on https://github.com/theADAMJR/newstarsgame.com.
This is what Discord doesn't allow you to do by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants