-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS-in-JS #9
Comments
I was thinking of the same idea, after reviewing the code... https://material-ui-next.com/customization/css-in-js/ The above explanation is a great use case for the css-in-js https://oliviertassinari.github.io/a-journey-toward-better-style Along with this presentation... |
However, it would be a lot of refactoring.... And in thinking about it further I am not sure it would be worth the effort. But at least there is some information here if you are curious... |
This is a short article on styled-components which shows some great benefits, including simpler more semantic JSX: |
I hesitated a bit to reply to this issue. I like the idea of using CSS grids, but on the other hand wouldn't want to add complexity to the repository itself. The focus shouldn't be on the style here, that's why I used simple CSS in the first place. What do you and others think about it? If I am the only one thinking this way, then we should go for your proposal! 👍 😃 |
Yeah, good point. I was thinking it would be a great example of CSS-in-JS. Maybe those interested can refactor offline to experiment. I'll have a crack :) |
Please post here after you do your experiment and/or if others do as well... |
Hi Robin, this looks awesome. Would you consider converting your CSS into styled-components? Including layout components with Grid Layout and Flexbox?
Cheers :)
The text was updated successfully, but these errors were encountered: