Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skill Test Targets Display #155

Merged

Conversation

MangoFVTT
Copy link
Collaborator

Type
What type of pull request is this? (e.g., Bug fix, Feature, Refactor, etc.)

  • Bug fix
  • Feature
  • Refactor
  • Other (please describe):

Description
Adds a collapsible list of actors that were targeted when the skill test was made. This list shows the appropriate defence values for each actor, and adds an indicator for whether or not each defence was beaten by the skill test. Target info is stored within the message flags, which means the card will persist even post reload, keeping a tray with the targets that were selected when it was made.

Related Issue
Closes #153.

How Has This Been Tested?
Tested with multiple actors targeted and ensure targets are stored into the message on refresh.

Screenshots (if applicable)
image

Checklist:

  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes do not introduce any new warnings or errors.
  • My PR does not contain any copyrighted works that I do not have permission to use.
  • I have tested my changes on Foundry VTT version: [insert version here].

@stanavdb stanavdb merged commit 910a940 into the-metalworks:release-0.1.2 Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants