Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for powers (e.g. surges) and path skills #124

Merged
merged 17 commits into from
Nov 4, 2024

Conversation

stanavdb
Copy link
Collaborator

@stanavdb stanavdb commented Oct 28, 2024

Type

  • Bug fix
  • Feature
  • Refactor
  • Other (please describe):

Description
This PR adds the necessary functionality for surge skills (including unlocking them). Surges have been modeled through the generic Power item. Powers are any (magical) ability linked to its own skill. Powers are set up so we can use them for the surges, but also allow support for other magic system (i.e. allomancy).
Beside Powers, this PR moves goals from the character data model to their own item (and includes migration). This allows us to embed rewards directly into goals, which is necessary for granting surges once the first ideal has been spoken.

Related Issue
Closes #88

Screenshots (if applicable)
image
image
image
image
image

Checklist:

  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes do not introduce any new warnings or errors.
  • My PR does not contain any copyrighted works that I do not have permission to use.
  • I have tested my changes on Foundry VTT version: 12.331.

@stanavdb stanavdb self-assigned this Oct 28, 2024
@stanavdb stanavdb marked this pull request as ready for review October 31, 2024 16:54
Copy link
Collaborator

@MangoFVTT MangoFVTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through all of this, nothing stands out as egregious and need to change to me. I'm sure there's improvements we'll have to make later but this good work to get us going 👍

@stanavdb stanavdb merged commit 41fec09 into release-0.1.2 Nov 4, 2024
1 check passed
@stanavdb stanavdb deleted the feat/path-skills-88 branch November 4, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants