-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for powers (e.g. surges) and path skills #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… items the actor already possesses
…when the granting talent is removed and re-added
…er already present on the actor
…ow up in actions list under "powers"
MangoFVTT
approved these changes
Nov 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through all of this, nothing stands out as egregious and need to change to me. I'm sure there's improvements we'll have to make later but this good work to get us going 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
This PR adds the necessary functionality for surge skills (including unlocking them). Surges have been modeled through the generic Power item. Powers are any (magical) ability linked to its own skill. Powers are set up so we can use them for the surges, but also allow support for other magic system (i.e. allomancy).
Beside Powers, this PR moves goals from the character data model to their own item (and includes migration). This allows us to embed rewards directly into goals, which is necessary for granting surges once the first ideal has been spoken.
Related Issue
Closes #88
Screenshots (if applicable)
Checklist: