Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Item chat descriptions #141

Open
1 task done
stanavdb opened this issue Oct 31, 2024 · 3 comments
Open
1 task done

Add support for Item chat descriptions #141

stanavdb opened this issue Oct 31, 2024 · 3 comments
Labels
feature request New feature good first issue Good for newcomers ui User interface related issue ux User experience related issue
Milestone

Comments

@stanavdb
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Some items need to have long descriptions, whose content isn't necessarily all relevant for the chat, but it gets added to the chat card anyway. This causes items which don't have a roll as part of their activation to put an incredibly long expanded message into the chat.

Describe the solution you'd like
Add support for alternate chat descriptions that are used in the chat message instead of the proper item description.

Describe alternatives you've considered

Version
0.1.1

Checklist:

  • I have searched the existing issues to ensure this feature has not already been requested.
@stanavdb stanavdb added ui User interface related issue ux User experience related issue feature request New feature labels Oct 31, 2024
@zithith
Copy link
Collaborator

zithith commented Nov 13, 2024

There is already "back-end" functionality to support different tiers of description (full/short/chat) this will effectively just need to provide a UI in the item description template for editing those, then passing through the chat option as the item's description when activated if it has one, otherwise fall back to short and then full.
@MangoFVTT do we think this falling back should be handled by the caller, or the chat message? We can just hand the whole description object into the message instead?

@MangoFVTT
Copy link
Collaborator

@MangoFVTT do we think this falling back should be handled by the caller, or the chat message? We can just hand the whole description object into the message instead?

As it currently works, the item generates the description HTML before ever reaching the chat message stage and just passes the entire HTML object containing the description to the chat message so it can be properly enriched. It should be relatively trivial to change what text is placed within that description HTML

@zithith
Copy link
Collaborator

zithith commented Nov 16, 2024 via email

@zithith zithith added the good first issue Good for newcomers label Nov 20, 2024
@zithith zithith added this to the Release 0.2.2 milestone Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature good first issue Good for newcomers ui User interface related issue ux User experience related issue
Projects
Status: Ready
Development

No branches or pull requests

3 participants