Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Plugin seems to be not working #66

Closed
deeplywithin opened this issue Nov 27, 2020 · 7 comments · Fixed by #76
Closed

Download Plugin seems to be not working #66

deeplywithin opened this issue Nov 27, 2020 · 7 comments · Fixed by #76

Comments

@deeplywithin
Copy link

Do you have any idea, how I could get this to work?

image

@th-ch
Copy link
Owner

th-ch commented Nov 27, 2020

Hey @deeplywithin, thanks for the feedback! The download plugin works only when playing a music in the foreground (not when exploring with the player being minimized), with URLs like https://music.youtube.com/watch?v=XXX&list=XXX (it will then download the music being played).

Does that answer your question? As for the ability to download a music being played while exploring YouTube Music, that's definitely a good improvement (and should be easy to implement) that I have in mind.

@th-ch th-ch added the awaiting-reply Awaiting reply label Nov 27, 2020
@AbhishekSehwag
Copy link

Desktop Screenshot 2020 12 02 - 08 58 43 38
Can't download music and i am curious to know where the music is saved.

@th-ch
Copy link
Owner

th-ch commented Dec 2, 2020

Hey @AbhishekSehwag, thanks for reporting the issue! Next version 1.6.5 should fix it with the merge of #76.
As for the folder where files are saved, it should be in the Downloads folder, depending on your OS.

v1.6.5 will be released soon, feel free to re-open the issue if needed!

@th-ch th-ch removed the awaiting-reply Awaiting reply label Dec 2, 2020
@AbhishekSehwag
Copy link

Hey @AbhishekSehwag, thanks for reporting the issue! Next version 1.6.5 should fix it with the merge of #76.
As for the folder where files are saved, it should be in the Downloads folder, depending on your OS.

v1.6.5 will be released soon, feel free to re-open the issue if needed!

Yeah man you are great, keep the good work going.

@AbhishekSehwag
Copy link

Hey @AbhishekSehwag, thanks for reporting the issue! Next version 1.6.5 should fix it with the merge of #76.
As for the folder where files are saved, it should be in the Downloads folder, depending on your OS.

v1.6.5 will be released soon, feel free to re-open the issue if needed!

Also It would be great if we can choose the quality of mp3 file (144kbps/320kbps)

@th-ch
Copy link
Owner

th-ch commented Dec 3, 2020

Also It would be great if we can choose the quality of mp3 file (144kbps/320kbps)

Hey @AbhishekSehwag, custom options have been added in v1.7.0! You can go to Plugins > Advanced options and edit the configuration, for example to have 320kbps:

"downloader": {
    "enabled": true,
    "ffmpegArgs": ["-b:a", "320k"]
},

Feel free to re-open the issue if something does not work as expected!

@AbhishekSehwag
Copy link

Also It would be great if we can choose the quality of mp3 file (144kbps/320kbps)

Hey @AbhishekSehwag, custom options have been added in v1.7.0! You can go to Plugins > Advanced options and edit the configuration, for example to have 320kbps:

"downloader": {
    "enabled": true,
    "ffmpegArgs": ["-b:a", "320k"]
},

Feel free to re-open the issue if something does not work as expected!

Thanks man, you are the most eager developer i have ever seen. Also the downloader is working well now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants