Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix path to fasmg or bad include for make.cmd and examples ? #1

Open
catafest opened this issue Jan 8, 2019 · 1 comment
Open

fix path to fasmg or bad include for make.cmd and examples ? #1

catafest opened this issue Jan 8, 2019 · 1 comment

Comments

@catafest
Copy link

catafest commented Jan 8, 2019

I think is a bug area of put fasmg on path and fix examples with set include folder
I suppose is need to add the fasmg on windows path and this let the set command to include the folder include.
I think is more good to set the path for examples to work with fasmg executable and not to add fasmg to windows path.
In this case the make.cmd come show this error:

C:\fasmg-master\core\examples\x86>fasmg win64avx.asm win64avx.exe

'fasmg' is not recognized as an internal or external command,
operable program or batch file.

The examples come with this include path and cannot access the real path fasmg-master\core\examples\x86\include\format, see:

include 'format\format.inc'   
@ScriptTiger
Copy link

There is no bug here. The fasmg.exe should be added to your environmental PATH variable. PATH is for executables/executable code (.exe, .dll, .com, .cmd, .bat, etc.) and INCLUDE is for includes (.inc), they are both independent from each other but work in a similar way for their intended file types, using the semicolon (;) to separate multiple entries. When the make.cmd is executed, it should find fasmg.exe from your PATH. make.cmd sets a single relative path of INCLUDE to include, which is the relative path to the include directory , which should be directly within your current working directory. The make.cmd cannot provide a full path since it's impossible to know what directory everyone will want to put their fasmg directory inside of.

The only reason the make.cmd will not be able to find the include directory is if you are trying to execute the make.cmd from a different working directory, such as opening a command prompt and leaving the working directory as the default C:\Users\catafest or something similar and not first changing the working directory (CD) to the make.cmd root directory, instead of the intended working directory which the make.cmd is directly inside of.

All you need to do is add fasmg.exe to your PATH variable and double-click make.cmd and it will work flawlessly. If you don't like how that works, that's your personal preference and you are free to rewrite all the batch files to your liking. Saying your personal preference is "more good" is highly subjective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants