Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Save button placement #1093

Open
jakeymac opened this issue Sep 17, 2024 · 3 comments
Open

[BUG] Save button placement #1093

jakeymac opened this issue Sep 17, 2024 · 3 comments

Comments

@jakeymac
Copy link
Contributor

Describe the bug
The save button's placement in the modals for saving services in Tethys settings is awkwardly placed too far to the right.

@jakeymac jakeymac added the bug label Sep 17, 2024
@jakeymac jakeymac self-assigned this Sep 17, 2024
@mattw-nws
Copy link
Contributor

#container has a min-width of 980px in base.css...the main table on the app settings admin page behaves the same it's just more obvious what's going on because of the content. The JS popup may just need to start the window with a width of 980 instead of whatever it starts with now, which seems to be 800px. Having trouble identifying the event handler that actually does the popup because of a Chrome extension on my system... but it almost certainly is JS somewhere (e.g. window.open()), because the location bar is hidden in the popup.

@jakeymac
Copy link
Contributor Author

Looks like this issue is fixed in Django 5, at least in version 5.1.1. The layout used in this popup comes from Django.

@swainn
Copy link
Member

swainn commented Nov 25, 2024

Since we are supporting Django 4, we should try to fix this for that version too. Should be a matter of tweaking some of the custom CSS for the admin pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants