chore: edit more comments about clippy

tesuji · May 31, 2024 · 408f562 · 408f562
1 parent c3d6518
commit 408f562
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -139,8 +139,7 @@ jobs:
           rustup toolchain install nightly -c clippy
           rustup default nightly
       - run: cargo fetch
-      - run: cargo clippy --all-targets --all-features -- -Dwarnings -A clippy::assertions-on-constants
-
+      - run: cargo clippy --all-targets --all-features -- -Dwarnings
 
   # Use static analyzer Rudra <https://github.com/sslab-gatech/Rudra>.
   # FIXME: Disable for now since it's very costly to run.

diff --git a/src/internals/c.rs b/src/internals/c.rs
@@ -30,12 +30,11 @@ pub use windows_sys::Win32::System::IO::DeviceIoControl;
 
 // Makes sure layout of RawHandle and windows-sys's HANDLE are the same
 // for pointer casts between them.
-// CLIPPY: nonsense suggestions for assert!
 #[allow(clippy::unnecessary_operation)]
 const _: () = {
     let std_layout = Layout::new::<RawHandle>();
     let win_sys_layout = Layout::new::<HANDLE>();
-    // MSVR(Rust v1.57): use assert! instead
+    // MSRV(Rust v1.57): use assert! instead
     [(); 1][std_layout.size() - win_sys_layout.size()];
     [(); 1][std_layout.align() - win_sys_layout.align()];
 };
@@ -49,6 +48,7 @@ pub const REPARSE_GUID_DATA_BUFFER_HEADER_SIZE: u16 = 24;
 pub const MOUNT_POINT_REPARSE_BUFFER_HEADER_SIZE: u16 = 8;
 
 #[cfg(feature = "nightly")]
+#[allow(clippy::assertions_on_constants)]
 const _: () = {
     assert!(REPARSE_DATA_BUFFER_HEADER_SIZE == nightly::REPARSE_DATA_BUFFER_HEADER_SIZE);
     assert!(REPARSE_GUID_DATA_BUFFER_HEADER_SIZE == nightly::REPARSE_GUID_DATA_BUFFER_HEADER_SIZE);

diff --git a/src/internals/helpers.rs b/src/internals/helpers.rs
@@ -50,7 +50,7 @@ fn set_privilege(write: bool) -> io::Result<()> {
                 c::SE_BACKUP_NAME
             }
         } else {
-            // FSCTL_SET_REPARSE_POINT requires SE_CREATE_SYMBOLIC_LINK_NAME privilege
+            // FSCTL_SET_REPARSE_POINT requires below privilege.
             // Ref <https://learn.microsoft.com/en-us/windows/win32/api/winioctl/ni-winioctl-fsctl_set_reparse_point>
             c::SE_CREATE_SYMBOLIC_LINK_NAME
         };