diff --git a/spec/features/teacher_has_admin_abilities_to_own_course_spec.rb b/spec/features/teacher_has_admin_abilities_to_own_course_spec.rb index fcbde7a4c..eac0c426f 100644 --- a/spec/features/teacher_has_admin_abilities_to_own_course_spec.rb +++ b/spec/features/teacher_has_admin_abilities_to_own_course_spec.rb @@ -74,20 +74,6 @@ expect(page).not_to have_content('0/6') end - scenario 'Teacher can make code review' do - visit '/org/slug/courses/1' - - expect(page).to have_content('1 code review requested') - click_link '1 code review requested' - click_link 'Requested' - # click_link 'Start code review' - - fill_in('review_review_body', with: 'Code looks ok') - - page.execute_script("$('form#new_review').submit()") - expect(page).to have_content('None at the moment.') - end - scenario 'Teacher can manage course feedback questions' do visit '/org/slug/courses/1' click_link 'Manage feedback questions' diff --git a/spec/usermanual/teachers.html.erb b/spec/usermanual/teachers.html.erb index a395152db..41b09ad7d 100644 --- a/spec/usermanual/teachers.html.erb +++ b/spec/usermanual/teachers.html.erb @@ -573,68 +573,6 @@ Some common examples:
-- Code reviewing is a process in which a course teacher or an assistant goes over the code in a submitted answer and reviews it, providing comments for the students. Some exercises require a codereview to be completed. Students can also manually request a code review. -
-- If there are any unreviewed requests, the course front page has a link 'n code view requested'. You can start the review process by clicking on that link. Furthermore, the submission list on the bottom of the page shows whether each submission requires a review. -
- - -<% - student = FactoryBot.create :verified_user, login: 'student', email: 'student@example.com' - course = Course.find(2) - exercise1 = course.exercises.find_by(name: 'Week1-HelloWorld') - submission = FactoryBot.create :submission, course: course, user: student, exercise: exercise1, requests_review: true - submission_data = FactoryBot.create :submission_data, submission: submission - available_point = FactoryBot.create :available_point, exercise: exercise1 - available_point.award_to(student, submission) - - visit '/org/hy/courses/2' - highlight 'a:contains("Requested")' - highlight 'a:contains("1 code review requested")' -%> -<%= screenshot %> - -- The Review page shows all submissions which still require reviews. Click the 'Requested' link for the submission you want to review. -
- -<% - click_on '1 code review requested' - highlight 'a:contains("Requested")' - -%> -<%= screenshot %> - -- On the review screen, you can see student's code at the bottom of the page. Test result visibility can be toggled by clicking 'Test results'. When you have looked the code, click 'Start code review' to write your feedback. -
- -<% - click_on 'Requested' - highlight 'button:contains("Start code review")' - -%> -<%= screenshot %> - -- Write you review text in the text area. If you want to notify the student by email, you can check 'Notify - by e-mail' checkbox. When you are ready, click 'Save review'. -
- - -<% - click_on 'Start code review' - fill_in 'review_review_body', with: 'Code looks ok but you could...' - highlight 'label:contains("Notify by e-mail")' - highlight 'button:contains("Save review")' - sleep 1 # to prevent javascript animation to be captured -%> -<%= screenshot %> -