Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 14.4.3 -> 14.5.0 causes error TS1005: ',' expected #1161

Open
nsbarsukov opened this issue Sep 15, 2023 · 1 comment
Open

Update 14.4.3 -> 14.5.0 causes error TS1005: ',' expected #1161

nsbarsukov opened this issue Sep 15, 2023 · 1 comment
Labels
bug Something isn't working needs assessment This needs to be looked at by a team member

Comments

@nsbarsukov
Copy link

nsbarsukov commented Sep 15, 2023

Reproduction example

taiga-family/maskito#507
taiga-family/maskito#518

Actual behavior

See https://github.com/taiga-family/maskito/actions/runs/6189000924/job/16802149821?pr=507

Error: node_modules/@testing-library/user-event/dist/types/clipboard/copy.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/clipboard/cut.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/clipboard/paste.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/convenience/click.d.ts(1,[15](https://github.com/taiga-family/maskito/actions/runs/6189000924/job/16802149821?pr=507#step:4:16)): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/convenience/hover.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/convenience/tab.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/event/dispatchEvent.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/event/input.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/event/selection/index.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/event/selection/modifySelectionPerMouse.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/event/selection/setSelectionPerMouse.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/index.d.ts(6,40): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/keyboard/index.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/options.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/options.d.ts(2,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/pointer/index.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/pointer/index.d.ts(2,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/pointer/index.d.ts(3,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/setup/directApi.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/setup/directApi.d.ts(2,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/setup/directApi.d.ts(3,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/setup/directApi.d.ts(4,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/system/keyboard.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/system/keyboard.d.ts(2,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/system/pointer/buttons.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/utility/clear.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/utility/selectOptions.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/utility/type.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/utility/type.d.ts(2,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/utility/upload.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/utils/misc/level.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/utils/misc/wait.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/utils/pointer/cssPointerEvents.d.ts(1,15): error TS1005: ',' expected.
Error: Process completed with exit code 2.

User-event version

14.5.0

Environment

No response

Additional context

No response

@raplemie
Copy link

import {type Options} from "...' were added in 14.5.0, this requires at least Typescript 4.5.0, otherwise it does not recognise the type parameter as a token and tries to import it. https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-5.html#type-modifiers-on-import-names

Your project probably uses an older version of typescript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs assessment This needs to be looked at by a team member
Projects
None yet
Development

No branches or pull requests

2 participants