Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: code smells #3655

Open
1 task done
AnthonySteffano opened this issue Nov 28, 2023 · 0 comments
Open
1 task done

[Fix]: code smells #3655

AnthonySteffano opened this issue Nov 28, 2023 · 0 comments
Assignees
Labels

Comments

@AnthonySteffano
Copy link

AnthonySteffano commented Nov 28, 2023

Related issue

We found code smells issues in the code, some errors are related to DOM, JSX, Large Component, Too many props.

In the first refactoring, we decided to divide it into smaller components, making the code more readable and modular. That's why we split the 'BackgroundLayerChooser' component into smaller subcomponents:

  • 'LayerCard': Represents the view of each individual layer.
  • 'ToggleBackgroundButton': Represents the button for toggling the visibility of layers.
  • 'BackgroundPreview': Represents the preview of the selected layer or background imag
  • 'BackgroundLayerMapComponent': Responsible for rendering the OpenLayers map.
  • 'LayerTitleComponent': Responsible for displaying the layer title.
  • 'LoadingSpinComponent': Responsible for displaying the loading spinner.
  • 'LayerPreviewContainer': Container component that gathers the other components.

Feature request

Code correction and restructuring

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@AnthonySteffano AnthonySteffano changed the title [Feature]: Fix code smells [Fix]: code smells Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants