Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with get_child_collections in Terrautils extractors.py #594

Open
2 tasks
Chris-Schnaufer opened this issue Jul 31, 2019 · 0 comments
Open
2 tasks

Comments

@Chris-Schnaufer
Copy link

Title: There are several issues with get_child_collections()

Tags: terrautils, extractor, get_child_collections

Description

There are some problems around the get_child_collections() function in terrautils/extractors.py

  1. It's defined multiple times
  2. There are calls (in extractors.py) to the function that are passing in a user name and password instead of a key (a key is what's expected)

Details

The calls to get_child_collections() in delete_dataset_metadata_in_collection and delete_datasets_in_collection will fail at run time.

The two declarations with the same name will result in only one or the other being active at run time. There's enough difference in intent between the two declarations that unexpected results may occur

Completion Criteria

  • Only one instance of get_child_collections() is defined
  • The calls to the function that have too many parameters are corrected, or another function is defined to handle their case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant