feat: alliance lp hub #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emidev98
force-pushed
the
init/alliance/lp/hub
branch
from
4ae6c93 to
e439487
Compare
emidev98
force-pushed
the
init/alliance/lp/hub
branch
from
e439487 to
4e9a0be
Compare
emidev98
force-pushed
the
init/alliance/lp/hub
branch
from
9e9729c to
2928a20
Compare
|
@emidev98 When unstaking tokens from the hub, we need to unstake them from the incentives contract as well. Else the LP tokens will still be stuck and cant be withdrawn |
|
Thanks! That makes a lot of sense, I'll check and implement that |
javiersuweijie
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduce a new smart contract in the alliance-protocol. This smart contract is a simplified version of AllianceHub, that does not require off-chain oracle and the re-balancing model is based on weights configured through governance.