Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octave-x: enable qt gui #21976

Merged
merged 3 commits into from
Oct 27, 2024
Merged

octave-x: enable qt gui #21976

merged 3 commits into from
Oct 27, 2024

Conversation

licy183
Copy link
Member

@licy183 licy183 commented Oct 25, 2024

Ref: #21868

@truboxl
Copy link
Contributor

truboxl commented Oct 25, 2024

Actually been want to ask why 2 octave-x in x11-repo and TUR?

@twaik
Copy link
Member

twaik commented Oct 25, 2024

Octave in tur is built with custom toolchain so it can be built for 32 bits too.

Copy link
Member

@twaik twaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case if you flip the gui toggle you should fix description because it mentions 'only cli'.

@licy183
Copy link
Member Author

licy183 commented Oct 26, 2024

I will merge it in 48 hours if there is no more review or when it gets 2+ approves. Thanks!

@twaik
Copy link
Member

twaik commented Oct 26, 2024

Should not you mention qt6-qttools-cross-tools in build dependencies in the case if regular qt6-qttools is used or it is not required?

@twaik
Copy link
Member

twaik commented Oct 26, 2024

LGTM.

@licy183
Copy link
Member Author

licy183 commented Oct 26, 2024

Should not you mention qt6-qttools-cross-tools in build dependencies in the case if regular qt6-qttools is used it is not required?

It is better to add it to build dependencies. But actually our building system will always fetch full dependencies, so if qt6-qttools is added in dependencies, qt6-qttools-cross-tools will be fetched too.

x11-packages/octave-x/build.sh Outdated Show resolved Hide resolved
x11-packages/octave-x/build.sh Outdated Show resolved Hide resolved
licy183 and others added 2 commits October 27, 2024 01:04
[skip ci]

Co-authored-by: Jia Yuan Lo <[email protected]>
[skip ci]

Co-authored-by: Jia Yuan Lo <[email protected]>
@licy183 licy183 merged commit 34d5fc5 into master Oct 27, 2024
@licy183 licy183 deleted the issue-21868 branch October 27, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants