-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
octave-x: enable qt gui #21976
octave-x: enable qt gui #21976
Conversation
Actually been want to ask why 2 octave-x in x11-repo and TUR? |
Octave in tur is built with custom toolchain so it can be built for 32 bits too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the case if you flip the gui toggle you should fix description because it mentions 'only cli'.
I will merge it in 48 hours if there is no more review or when it gets 2+ approves. Thanks! |
Should not you mention |
LGTM. |
It is better to add it to build dependencies. But actually our building system will always fetch full dependencies, so if |
[skip ci] Co-authored-by: Jia Yuan Lo <[email protected]>
[skip ci] Co-authored-by: Jia Yuan Lo <[email protected]>
Ref: #21868