chore(x11/mpv): make X11 default backend #21892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomJo2000
reviewed
Oct 19, 2024
twaik
force-pushed
the
mpv-fix-default
branch
from
afc3177 to
2a73e2d
Compare
|
Patching it is definitely the better approach but we could also set a default using the |
|
This change may break user's setup. |
|
Also anyway mediacodec backend requires JNI so it is useless... |
|
Yeah patching is definitely the better solution here. |
licy183
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default mpv chooses wrong video backend and shows this:
This patch fixes it.
I will merge it in 72 hours if no one minds.
Or anyone else can merge it earlier.