Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename store and storage modules to make them less confusing #78

Open
spl opened this issue Jun 30, 2021 · 5 comments
Open

Rename store and storage modules to make them less confusing #78

spl opened this issue Jun 30, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@spl
Copy link
Contributor

spl commented Jun 30, 2021

This is an issue where we track ideas for names that we would like to consider changing. We may come back to this in the future to wrap them all up together in one big change.

@github-actions github-actions bot added the triage issue to be triage label Jun 30, 2021
@spl
Copy link
Contributor Author

spl commented Jun 30, 2021

Having modules named store and storage is confusing.

@spl
Copy link
Contributor Author

spl commented Jun 30, 2021

Having “named graph” and “label” threw me off a bit. I eventually realized that the label is the name of the named graph. What if we called it a labeled graph? Then, it's immediately clear that the label is for the labeled graph.

Also, I see “database” and “named graph” used somewhat interchangeably in places. Perhaps consistency would be better there.

@spl
Copy link
Contributor Author

spl commented Jun 30, 2021

type File in PersistentLayerStore. The type is not necessarily a file.

@matko
Copy link
Member

matko commented Jul 5, 2021

PersistentLayerStore doesn't have to be persistent so the name is actually wrong.

@spl spl added enhancement New feature or request and removed triage issue to be triage labels Jul 5, 2021
@spl
Copy link
Contributor Author

spl commented Jul 6, 2021

This is something I've seen in terminusdb, but I'm putting it here for now. I've seen these variable names, and they all seem to refer to the same thing:

  • Name
  • Graph_ID
  • Graph_Name
  • DB_Name
  • Db/DB
  • Instance_Label/Schema_Label
  • Composite
  • Repo_Name
  • Ref_Name

@spl spl changed the title Renaming Rename store and storage modules to make them less confusing Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants