You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't understand where this is coming from, but this should be fixed, Node v8 is even explicitly listed as unsupported in package.json, and this issue cases the already not super lightweight library to be included twice in bundled terminal apps, which is not good. (bundling improves startup time, which is important for terminal apps).
To Reproduce
Compare the index.js from github and npm.
Expected behavior
Prompts should be only imported once, in a bundler-friendly manner, besides these differences in the package between what's in the repo and what's published raise security concern eyebrows in general.
System
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered:
Version 2.4.2 is the latest release. There have been 4 commits on master since then. Both of the changes mentioned above are more recent than the last release.
You can see the differences between 2.4.2 and masterhere.
Discontinuing support for previous node versions requires a major version change (so 3.x.x). I've outlined a few ideas for what a 3.0 release might look like in #393.
Describe the bug
index.js
in the repo looks like this:But on NPM it actually looks like this:
I don't understand where this is coming from, but this should be fixed, Node v8 is even explicitly listed as unsupported in
package.
json, and this issue cases the already not super lightweight library to be included twice in bundled terminal apps, which is not good. (bundling improves startup time, which is important for terminal apps).To Reproduce
Compare the
index.js
from github and npm.Expected behavior
Prompts should be only imported once, in a bundler-friendly manner, besides these differences in the package between what's in the repo and what's published raise security concern eyebrows in general.
System
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: