feat: init css on print #18 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: storybook test, are borken right now. |
frodrigo
force-pushed
the
develop
branch
2 times, most recently
from
c42e4f7 to
9ea01ee
Compare
joselegitan
force-pushed
the
feat18/add-css-to-detail-print
branch
from
37dd7f0 to
89e5465
Compare
frodrigo
changed the title
frodrigo
force-pushed
the
feat18/add-css-to-detail-print
branch
from
89e5465 to
9ee5fff
Compare
|
Rebased. Still need improvement #18 (comment) |
frodrigo
force-pushed
the
develop
branch
2 times, most recently
from
08e8715 to
fcbade9
Compare
frodrigo
force-pushed
the
develop
branch
7 times, most recently
from
704a333 to
c7465cd
Compare
|
Please, can you rebase, or port the PR to the current |
|
Looks good on "large" layout. But there is also small map layout with or without photo. Like http://127.0.0.1:3000/poi/33500/details or http://127.0.0.1:3000/poi/33726/details On the first the map is still broken. |
|
Please, can you rebase this PR. |
|
done |
frodrigo
force-pushed
the
feat18/add-css-to-detail-print
branch
from
da1c80f to
a6c177c
Compare
I replaced the merge by a rebase on the branch |
|
Ok, let merge it. Thank you. |
frodrigo
pushed a commit
that referenced
this pull request
Nov 8, 2023
frodrigo
pushed a commit
that referenced
this pull request
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft do not hesitate to tell me the modification needed