Contrib Mode

[wazolab]

I think we have to add fr translation for new list headers entries editor_id, osm_note, mapillary_link
And translation in spanish local file for editor_id, osm_note:

[frodrigo]

Does work from any pages (at least main map and category list) ?

[wazolab]

Does work from any pages (at least main map and category list) ?

yes It does !

[wazolab]

Here we have the whole logic within a middleware file, which is not the best in my opinion.
On a next work about Contribution, we could convert this code into a Nuxt Module.
This way we would isolate from the main codebase:

• the store
• middleware
• utility functions
• UI component
• Types
• Maybe translations (by merging them within our main translation files)

[frodrigo]

Please, can you add an entry into the README on how to use this feature.

[frodrigo]

The mapillary link does not appear in the POICard.

• http://localhost:3000/217/21107?contrib=true#map=16.93/43.576554/-1.487725
• but we have it in the details http://localhost:3000/poi/21107/details

The contrib mode is or not persisted to local storage, I does not see it working ?

[wazolab]

I can add MapillaryLink to POICard of course. I though from the specs it was unwanted here ...

In fact it's not, I though it was thanks to pinia-shared-state doing the job with localStorage, but we have to activate it by store (disabled by default ... I didn't see it :/ )

[frodrigo]

I can add MapillaryLink to POICard of course. I though from the specs it was unwanted here ...

Right. Note, from the issue is also required to do in in the detail pages, (there is already and osm link in the footer to be removed)

[wazolab]

(there is already and osm link in the fo

Are we talking about this Lat / Long link ?

[wazolab]

Alright, do we need to remove only © OpenStreetMap contributors ?

[frodrigo]

No, the link to osm.org from the date.

[wazolab]

Do I need to add mapillary_link in Details page as we already have it under Mapillary Image ?

[frodrigo]

Do I need to add mapillary_link in Details page as we already have it under Mapillary Image ?

Yes, because the image is a configurable field.

[wazolab]

I can add MapillaryLink to POICard of course. I though from the specs it was unwanted here ...

Right. Note, from the issue is also required to do in in the detail pages, (there is already and osm link in the footer to be removed)

Should we remove this link only on Contributor Mode or for every one ?

[frodrigo]

I can add MapillaryLink to POICard of course. I though from the specs it was unwanted here ...

Right. Note, from the issue is also required to do in in the detail pages, (there is already and osm link in the footer to be removed)

Should we remove this link only on Contributor Mode or for every one ?

For every one, was "quick" contrib mode hack.

[frodrigo]

Contrib column lost on list when switching category client side.

[wazolab]

Contrib column lost on list when switching category client side.

Yes, I need to add the poi.properties contrib transformation on PoisList watcher level.

Note: It would be more convenient to have all the data processing on pages/category/[id].vue level, for the moment I am forced to duplicate code.

[wazolab]

Translation are also missing for group_contrib (detail) and contrib (list).

Should I add them in local i18n or do we integrate it from Translations API ?
I think it's better from API because it will integrate straight with frontend and it might be low cost of work (just add the keys in API response) ?

If I do it in frontend, I need to isolate contrib case on FieldsHeader as it's based on Translations API:

<FieldsHeader
  v-if="field.label"
  :recursion-stack="recursionStack"
  :class="`field_header_level_${recursionStack.length}`"
>
  {{ fieldTranslateK(field.field) }}
</FieldsHeader>

[frodrigo]

Like the fields settings, you could inject if in the translations from the API ?

[frodrigo]

Each time we come back to a POICard it add new fields

[wazolab]

Like the fields settings, you could inject if in the translations from the API ?

Yes from GET /attribute_translations/fr.json
I don't really know how this Translations API works ... Does Translations API is linked to fields settings ?

• For the moment we are using editorial.(fields_group | popup_group | details_group) in order to have fields keys and pass it to $propertyTranslations and then query Translations API.
• As we have contrib and group_contrib fields added on top of editorial, we just need to pass the fields to $propertyTranslations and then query Translations API.
• Later we could add contrib and group_contrib fields to GET /pois/category/${categoryId}.${options.format} in order to have a full integration of the Contrib Mode.

What do you think ?

[wazolab]

Each time we come back to a POICard it add new fields

Fix here

[wazolab]

PR updated, now we are injecting Contrib fields on templates, instead of key addition in data.
I've created a Mixin for code reuse.