Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update display for route in detail page #134

Merged
merged 7 commits into from
Dec 4, 2023
Merged

feat: update display for route in detail page #134

merged 7 commits into from
Dec 4, 2023

Conversation

joselegitan
Copy link
Contributor

#41

@joselegitan joselegitan requested a review from frodrigo November 3, 2023 11:04
@joselegitan joselegitan self-assigned this Nov 3, 2023
@frodrigo
Copy link
Member

frodrigo commented Nov 6, 2023

I have a typescript error with this PR

lib/markerLayerFactory.ts:194:42 - error TS2339: Property 'findIndex' does not exist on type 'PropType<ApiPoi[]>'.
  Property 'findIndex' does not exist on type 'new (...args: any[]) => ApiPoi[]'.

194               const index = initFeatures.findIndex(

@frodrigo
Copy link
Member

frodrigo commented Nov 6, 2023

  • Maybe use bold for the numbers.
  • The list under the map should also contain the same numbers.

image

@frodrigo
Copy link
Member

frodrigo commented Nov 8, 2023

I rebased the branch and made changes about naming.

@frodrigo
Copy link
Member

frodrigo commented Nov 8, 2023

  • PoisDeck should contain the numbering directly, the compo is used in other places
  • The numbering should only be for wyapoint, not for other POI types. Look at ApiRouteWaypointType.

@frodrigo frodrigo merged commit b0e1478 into develop Dec 4, 2023
5 checks passed
@wazolab wazolab deleted the feat/41 branch April 9, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants