Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back TTMetal Dialect tests to generate flatbuffer .ttm for CI Runs #602

Closed
kmabeeTT opened this issue Sep 3, 2024 · 1 comment
Closed
Assignees

Comments

@kmabeeTT
Copy link
Contributor

kmabeeTT commented Sep 3, 2024

Looks like they got mistakenly removed due to https://github.com/tenstorrent/tt-mlir/pull/578/files#diff-cb5555bbe8903cbdc6d6db76786b0a73ee1f999fbd22fc3f660c4b487daf58bf removing --ttmetal-serialize-to-binary="output=%t.ttm" from .mlir files resulting in no .ttm generated, resulting in no TTMetal tests run.

Easy fix to update the 3x TTMetal files to generate .ttm using new syntax advertised in that PR, ex:

./build/bin/ttmlir-opt --ttir-load-system-desc="path=ttrt-artifacts/system_desc.ttsys" --ttir-implicit-device --ttir-allocate --convert-ttir-to-ttmetal test/ttmlir/Silicon/TTMetal/to_layout.mlir | ./build/bin/ttmlir-translate --ttmetal-to-flatbuffer

FYI @rpavlovicTT

@kmabeeTT kmabeeTT self-assigned this Sep 3, 2024
kmabeeTT added a commit that referenced this issue Sep 3, 2024
…tmetal-to-flatbuffer" (#602)

 - Needed after 5d60c17 today otherwise tests don't run on CI
@kmabeeTT
Copy link
Contributor Author

kmabeeTT commented Sep 4, 2024

Meged PR #603 , marking closed.

@kmabeeTT kmabeeTT closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant