Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTIR Select op should be renamed #1675

Open
mrakitaTT opened this issue Dec 27, 2024 · 0 comments
Open

TTIR Select op should be renamed #1675

mrakitaTT opened this issue Dec 27, 2024 · 0 comments

Comments

@mrakitaTT
Copy link
Contributor

mrakitaTT commented Dec 27, 2024

We currently have TTIR_SelectOp which was added to match the Forge Select op. We should choose a different name for this op in TTIR, because in all other dialects Select is used interchangeably for the same op as the Where op (which we also have in TTIR), so it is very confusing that we have both Select and Where and they are different ops.

Note that this change will break the Forge FE, so it should be done in phases if we care about not temporarily breaking the Forge FE (add renamed op in TTIR, change the Forge FE, delete Select op from TTIR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant