Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract createDataMovementThread function to a common place #1159

Open
rpavlovicTT opened this issue Nov 5, 2024 · 0 comments
Open

Extract createDataMovementThread function to a common place #1159

rpavlovicTT opened this issue Nov 5, 2024 · 0 comments
Assignees
@nsmithtt
Labels
MLIR Compiler
Milestone
[Metal Direct 0]

Comments

@rpavlovicTT
Copy link
Contributor

Right now createDataMovementThread is used in 2 contexts

  1. Creating data movement threads when lowering ToLayout ops,
  2. Creating data movement threads when lowering Generic ops.

Code is reused but in a ugly way, as this function is static and belongs to Layout rewriter instead being in a common place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nsmithtt nsmithtt

Labels
MLIR Compiler
Projects
None yet
Milestone
[Metal Direct 0]
Development

No branches or pull requests
2 participants
@nsmithtt @rpavlovicTT