Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StableHLO to TTIR conversion for remainder OP #1041

Closed
mrakitaTT opened this issue Oct 23, 2024 · 2 comments · Fixed by #1126
Closed

Add StableHLO to TTIR conversion for remainder OP #1041

mrakitaTT opened this issue Oct 23, 2024 · 2 comments · Fixed by #1126
Assignees
@kmitrovicTT
Labels
MLIR Ops Issues related to MLIR dialect ops and their implementations Priority Model Op Bringup Label for priority model ops
Milestone
[Third Party] HLO...

Comments

@mrakitaTT
Copy link
Contributor

Add support for StableHLO to TTIR conversion for remainder OP, lower to ttnn and add unit tests to tt-torch and tt-xla.

Can be lowered to ttnn.remainder.
@mrakitaTT mrakitaTT added this to the [Third Party] HLO + XLA milestone Oct 23, 2024
@kmitrovicTT kmitrovicTT self-assigned this Oct 31, 2024
@kmitrovicTT kmitrovicTT mentioned this issue Oct 31, 2024
Merged
@kmitrovicTT kmitrovicTT added the MLIR Ops Issues related to MLIR dialect ops and their implementations label Nov 7, 2024
@staylorTT staylorTT added the Priority Model Op Bringup Label for priority model ops label Nov 7, 2024
@kmitrovicTT kmitrovicTT reopened this Nov 8, 2024
@kmitrovicTT
Copy link
Contributor

Jax and torch tests not written. Reopening issue.

This was referenced Nov 8, 2024
Closed
Closed
@kmitrovicTT
Copy link
Contributor

Op itself and conversion added in tt-mlir PR, jax tests added in tt-xla PR and torch tests added in tt-torch PR. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmitrovicTT kmitrovicTT

Labels
MLIR Ops Issues related to MLIR dialect ops and their implementations Priority Model Op Bringup Label for priority model ops
Projects
None yet
Milestone
[Third Party] HLO + XLA
Development

Successfully merging a pull request may close this issue.

Added support for stablehlo.remainder op. tenstorrent/tt-mlir
3 participants
@staylorTT @mrakitaTT @kmitrovicTT