Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytest tests/tt_eager/python_api_testing/unit_testing/misc/test_ssm_prefix_scan.py::test_ssm_reduce[32-32-32-1-dtype0] fails without L1 clear #9831

Closed
aliuTT opened this issue Jun 28, 2024 · 0 comments · Fixed by #9776
Closed

pytest tests/tt_eager/python_api_testing/unit_testing/misc/test_ssm_prefix_scan.py::test_ssm_reduce[32-32-32-1-dtype0] fails without L1 clear #9831

aliuTT opened this issue Jun 28, 2024 · 0 comments · Fixed by #9776
Assignees
@esmalTT

Comments

@aliuTT
Copy link
Contributor

aliuTT commented Jun 28, 2024

For minimum repro, on N300

git checkout main
"reset machine"
TT_METAL_CLEAR_L1=0 pytest tests/tt_eager/python_api_testing/unit_testing/misc/test_ssm_prefix_scan.py::test_ssm_reduce[32-32-32-1-dtype0]
@esmalTT esmalTT mentioned this issue Jun 30, 2024
Merged
@esmalTT esmalTT linked a pull request Jun 30, 2024 that will close this issue
Support longer sequence lengths in ssm_prefix_scan #9776
Merged
esmalTT added a commit that referenced this issue Jun 30, 2024
@esmalTT
#0: Support longer sequence legnths in ssm_prefix_scan
524feea 
This change adds support for L > 32 in `ssm_eltwise_mul`. Logically this
op can now handle any value of L but values of L > 128 will run out of
L1 in `bfloat8` format.

This change also fixes #9831.
esmalTT added a commit that referenced this issue Jun 30, 2024
@esmalTT
#0: Support longer sequence legnths in ssm_prefix_scan
fc80603 
This change adds support for L > 32 in `ssm_eltwise_mul`. Logically this
op can now handle any value of L but values of L > 128 will run out of
L1 in `bfloat8` format.

This change also fixes #9831.
esmalTT added a commit that referenced this issue Jun 30, 2024
@esmalTT
#0: Support longer sequence legnths in ssm_prefix_scan
d62da2c 
This change adds support for L > 32 in `ssm_eltwise_mul`. Logically this
op can now handle any value of L but values of L > 128 will run out of
L1 in `bfloat8` format.

This change also fixes #9831.
kpaigwar pushed a commit that referenced this issue Jul 1, 2024
@esmalTT @kpaigwar
#0: Support longer sequence legnths in ssm_prefix_scan
fd6173f 
This change adds support for L > 32 in `ssm_eltwise_mul`. Logically this
op can now handle any value of L but values of L > 128 will run out of
L1 in `bfloat8` format.

This change also fixes #9831.
esmalTT added a commit that referenced this issue Jul 2, 2024
@esmalTT
#0: Support longer sequence legnths in ssm_prefix_scan
d5da023 
This change adds support for L > 32 in `ssm_eltwise_mul`. Logically this
op can now handle any value of L but values of L > 128 will run out of
L1 in `bfloat8` format.

This change also fixes #9831.
@esmalTT esmalTT closed this as completed in 4a8f2da Jul 2, 2024
aliuTT added a commit that referenced this issue Jul 4, 2024
@aliuTT
#9831: re-enable test
f20e1ba
aliuTT added a commit that referenced this issue Jul 4, 2024
@aliuTT
#9831: re-enable test
86c140c
aliuTT added a commit that referenced this issue Jul 4, 2024
@aliuTT
#9831: re-enable test
27cbc9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esmalTT esmalTT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support longer sequence lengths in ssm_prefix_scan tenstorrent/tt-metal
2 participants
@aliuTT @esmalTT