Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate old interleaved_to_sharded #7735

Open
TT-BrianLiu opened this issue Apr 22, 2024 · 3 comments
Open

Deprecate old interleaved_to_sharded #7735

TT-BrianLiu opened this issue Apr 22, 2024 · 3 comments
Assignees
@TT-BrianLiu
Labels
bug Something isn't working op_cat: TM P1

Comments

@TT-BrianLiu
Copy link
Contributor

TT-BrianLiu commented Apr 22, 2024 •
edited
Loading

This version of interleaved_to_sharded has incorrect logic for BLOCK sharding. It's unncessary.
Tests in tests/tt_eager/python_api_testing/unit_testing/misc/test_sharded.py with BLOCK sharded fails and need to be re-enabled.

image
@TT-BrianLiu TT-BrianLiu added the bug Something isn't working label Apr 22, 2024
@TT-BrianLiu TT-BrianLiu self-assigned this Apr 22, 2024
@jliangTT
Copy link

@TT-BrianLiu , are you working on this or i should mark it as todo

@TT-BrianLiu
Copy link
Contributor Author

TODO. This is low priority

@eyonland eyonland mentioned this issue Oct 15, 2024
Open
@prajaramanTT
Copy link

@TT-BrianLiu Can we close this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TT-BrianLiu TT-BrianLiu

Labels
bug Something isn't working op_cat: TM P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TT-BrianLiu @jliangTT @prajaramanTT