-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some group_norm tests are failing in debug build #15868
Labels
Comments
On GS with Debug:
produces
|
bbradelTT
added a commit
that referenced
this issue
Dec 16, 2024
6 tasks
bbradelTT
added a commit
that referenced
this issue
Dec 17, 2024
bbradelTT
added a commit
that referenced
this issue
Jan 8, 2025
### Ticket Link to Github Issue #15868 ### Problem description - Some group norm tests are failing with Debug Build with an assert about CB size - The underlying reason is that the in0 CB was always sized to the nearest tile, even when the input was row major and therefore smaller ### What's changed - Set the CB size for in0 based on the per bank size to get the right size for row major and tile input ### Checklist - [x] Post commit CI passes across https://github.com/tenstorrent/tt-metal/actions/runs/12360041457 and https://github.com/tenstorrent/tt-metal/actions/runs/12374697868 all sub-jobs pass at least once - [x] Blackhole Post commit (if applicable) https://github.com/tenstorrent/tt-metal/actions/runs/12360044285 - [x] Model regression CI testing passes (if applicable) https://github.com/tenstorrent/tt-metal/actions/runs/12360048449 - [x] Device performance regression CI testing passes (if applicable) https://github.com/tenstorrent/tt-metal/actions/runs/12360046481 - [ ] **(For models and ops writers)** Full [new models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) tests passes - [x] New/Existing tests provide coverage for changes (in Debug)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Repro steps:
pytest tests/ttnn/unit_tests/operations/test_group_norm.py::test_group_norm_with_block_sharded_v2_8x8_grid
pytest tests/ttnn/unit_tests/operations/test_group_norm.py::test_group_norm_with_block_sharded_v2_8x8_grid_tile_layout
Expected Behaviour:
Actual Behaviour:
See tenstorrent/pytorch2.0_ttnn#538
Might be related to bad CB handling, e.g. see #15458
The text was updated successfully, but these errors were encountered: