Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD_SHARED_LIBS project option impacts all depenndencies #15604

Open
blozano-tt opened this issue Dec 2, 2024 · 0 comments
Open

BUILD_SHARED_LIBS project option impacts all depenndencies #15604

blozano-tt opened this issue Dec 2, 2024 · 0 comments
Assignees

Comments

@blozano-tt
Copy link
Contributor

We use the CMake customary cache variable "BUILD_SHARED_LIBS" to determine if we should build our libraries as static or shared.

option(BUILD_SHARED_LIBS "Create shared libraries" ON)

This variable globally impacts all of the dependencies we bring in through CPM, including those brought in by UMD's CPM. So if it is set, then nng ends up being a shared library.

We don't really want BUILD_SHARED_LIBS to globally impact our dependencies.

Maybe we should have something like METALIUM_BUILD_SHARED_LIBS as a project option, and then set BUILD_SHARED_LIBS

cc: @afuller-TT @broskoTT

Originally posted by @blozano-tt in #15527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants