-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphCapture doesn't recognise CBs with globally allocated addresses #12624
Comments
derdeljanTT
added a commit
that referenced
this issue
Oct 31, 2024
5 tasks
derdeljanTT
added a commit
that referenced
this issue
Nov 1, 2024
derdeljanTT
added a commit
that referenced
this issue
Nov 4, 2024
derdeljanTT
added a commit
that referenced
this issue
Nov 4, 2024
derdeljanTT
added a commit
that referenced
this issue
Nov 4, 2024
ct-clmsn
pushed a commit
to ct-clmsn/tt-metal
that referenced
this issue
Nov 12, 2024
…pture (tenstorrent#14521) * tenstorrent#12624: Fix tracking of globally allocated CBs in graph capture * tenstorrent#12624: Update graph tracing docs
#14521 merged, closing this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Graph capture doesn't recognise that CBs with globally allocated addresses will share space with the corresponding sharded input / output operand and no additional bytes will be allocated.
To Reproduce
Go to branch
derdeljan/graph-capture-cbs-repro
, build tt-metal and run./build_Debug/test/ttnn/unit_tests_ttnn --gtest_filter=MlirInterfaceTests/EltwiseUnaryOpInterfaceTestFixture.MlirInterfaceTest/0
(on a lab machine). Repro test definition is in the filetests/ttnn/unit_tests/gtests/test_graph_capture_repro.cpp
.We can see from the logs:
that the two CBs being allocated in unary sharded program factory have the sam address as the corresponding operand, however graph capture reports as if the new space will be allocated:
Full trace:
Expected behavior
Graph capture should recognise that no new space will be allocated for the above-mentioned CBs.
The text was updated successfully, but these errors were encountered: