Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Dispatch Write Functions to Remove Orphan Writes #11092

Closed
tt-asaigal opened this issue Aug 5, 2024 · 1 comment
Closed

Restructure Dispatch Write Functions to Remove Orphan Writes #11092

tt-asaigal opened this issue Aug 5, 2024 · 1 comment

Comments

@tt-asaigal
Copy link
Contributor

process_write_linear, process_write_paged and process_write_packed_large can be made simpler if we write up to the fence or data length (whichever one comes first), rather than writing single pages and accounting for orphan writes.

These functions got more complex starting at a5a94b4, where orphan writes needed to be accounted for upon block completion.

Writing up to the fence would also allow for the prefetch - dispatch pipeline to be better balanced:

For large txns, writing up to the fence would allow larger writes from the dispatcher (if prefetcher is ahead), thus speeding up dispatch.

Conversely, if dispatcher is ahead, the write size would decrease (the rate at which the fence progresses would be lower), slowing down the dispatcher.

@tt-asaigal
Copy link
Contributor Author

fyi @pgkeller @tt-aho

tt-asaigal added a commit that referenced this issue Aug 5, 2024
  - process_write_linear, process_write_paged and process_write_packed_large
    will now write up to the fence
tt-asaigal added a commit that referenced this issue Aug 5, 2024
  - process_write_linear, process_write_paged and process_write_packed_large
    will now write up to the fence
tt-asaigal added a commit that referenced this issue Aug 6, 2024
  - process_write_linear, process_write_paged and process_write_packed_large
    will now write up to the fence
tt-asaigal added a commit that referenced this issue Aug 6, 2024
  - process_write_linear, process_write_paged and process_write_packed_large
    will now write up to the fence
tt-asaigal added a commit that referenced this issue Aug 6, 2024
…1093)

- process_write_linear, process_write_paged and process_write_packed_large
    will now write up to the fence
sankarmanoj-tt pushed a commit that referenced this issue Aug 11, 2024
…1093)

- process_write_linear, process_write_paged and process_write_packed_large
    will now write up to the fence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant