diff --git a/tt_metal/llrt/blackhole/bh_hal_active_eth.cpp b/tt_metal/llrt/blackhole/bh_hal_active_eth.cpp index 2fe01d1cd57d..2fc27ed09ca4 100644 --- a/tt_metal/llrt/blackhole/bh_hal_active_eth.cpp +++ b/tt_metal/llrt/blackhole/bh_hal_active_eth.cpp @@ -29,7 +29,6 @@ HalCoreInfoType create_active_eth_mem_map() { mem_map_bases.resize(static_cast(HalL1MemAddrType::COUNT)); mem_map_bases[static_cast(HalL1MemAddrType::BASE)] = 0x0; // Anything better to use? - mem_map_bases[static_cast(HalL1MemAddrType::BARRIER)] = eth_l1_mem::address_map::ERISC_BARRIER_BASE; mem_map_bases[static_cast(HalL1MemAddrType::MAILBOX)] = eth_l1_mem::address_map::ERISC_MEM_MAILBOX_BASE; mem_map_bases[static_cast(HalL1MemAddrType::LAUNCH)] = GET_ETH_MAILBOX_ADDRESS_HOST(launch); @@ -44,8 +43,6 @@ HalCoreInfoType create_active_eth_mem_map() { mem_map_bases[static_cast(HalL1MemAddrType::GO_MSG)] = GET_ETH_MAILBOX_ADDRESS_HOST(go_message); mem_map_bases[static_cast(HalL1MemAddrType::LAUNCH_MSG_BUFFER_RD_PTR)] = GET_ETH_MAILBOX_ADDRESS_HOST(launch_msg_rd_ptr); - mem_map_bases[static_cast(HalL1MemAddrType::FW_VERSION_ADDR)] = - eth_l1_mem::address_map::FW_VERSION_ADDR; mem_map_bases[static_cast(HalL1MemAddrType::BANK_TO_NOC_SCRATCH)] = eth_l1_mem::address_map::ERISC_MEM_BANK_TO_NOC_SCRATCH; @@ -53,7 +50,6 @@ HalCoreInfoType create_active_eth_mem_map() { mem_map_sizes.resize(static_cast(HalL1MemAddrType::COUNT)); mem_map_sizes[static_cast(HalL1MemAddrType::BASE)] = eth_l1_mem::address_map::MAX_SIZE; // Anything better to use? - mem_map_sizes[static_cast(HalL1MemAddrType::BARRIER)] = eth_l1_mem::address_map::ERISC_BARRIER_SIZE; mem_map_sizes[static_cast(HalL1MemAddrType::MAILBOX)] = eth_l1_mem::address_map::ERISC_MEM_MAILBOX_SIZE; mem_map_sizes[static_cast(HalL1MemAddrType::LAUNCH)] = sizeof(launch_msg_t); @@ -66,7 +62,6 @@ HalCoreInfoType create_active_eth_mem_map() { eth_l1_mem::address_map::MAX_SIZE - eth_l1_mem::address_map::ERISC_L1_UNRESERVED_BASE; mem_map_sizes[static_cast(HalL1MemAddrType::GO_MSG)] = sizeof(go_msg_t); mem_map_sizes[static_cast(HalL1MemAddrType::LAUNCH_MSG_BUFFER_RD_PTR)] = sizeof(std::uint32_t); - mem_map_sizes[static_cast(HalL1MemAddrType::FW_VERSION_ADDR)] = sizeof(std::uint32_t); mem_map_sizes[static_cast(HalL1MemAddrType::BANK_TO_NOC_SCRATCH)] = eth_l1_mem::address_map::ERISC_MEM_BANK_TO_NOC_SIZE; diff --git a/tt_metal/llrt/blackhole/bh_hal_idle_eth.cpp b/tt_metal/llrt/blackhole/bh_hal_idle_eth.cpp index 72ba9e91a226..bd29e6665643 100644 --- a/tt_metal/llrt/blackhole/bh_hal_idle_eth.cpp +++ b/tt_metal/llrt/blackhole/bh_hal_idle_eth.cpp @@ -36,7 +36,6 @@ HalCoreInfoType create_idle_eth_mem_map() { mem_map_bases.resize(static_cast(HalL1MemAddrType::COUNT)); mem_map_bases[static_cast(HalL1MemAddrType::BASE)] = MEM_ETH_BASE; - mem_map_bases[static_cast(HalL1MemAddrType::BARRIER)] = MEM_L1_BARRIER; mem_map_bases[static_cast(HalL1MemAddrType::MAILBOX)] = MEM_IERISC_MAILBOX_BASE; mem_map_bases[static_cast(HalL1MemAddrType::LAUNCH)] = GET_IERISC_MAILBOX_ADDRESS_HOST(launch); mem_map_bases[static_cast(HalL1MemAddrType::WATCHER)] = GET_IERISC_MAILBOX_ADDRESS_HOST(watcher); @@ -54,7 +53,6 @@ HalCoreInfoType create_idle_eth_mem_map() { std::vector mem_map_sizes; mem_map_sizes.resize(static_cast(HalL1MemAddrType::COUNT)); mem_map_sizes[static_cast(HalL1MemAddrType::BASE)] = MEM_ETH_SIZE; - mem_map_sizes[static_cast(HalL1MemAddrType::BARRIER)] = sizeof(std::uint32_t); mem_map_sizes[static_cast(HalL1MemAddrType::MAILBOX)] = MEM_IERISC_MAILBOX_SIZE; mem_map_sizes[static_cast(HalL1MemAddrType::LAUNCH)] = sizeof(launch_msg_t); mem_map_sizes[static_cast(HalL1MemAddrType::WATCHER)] = sizeof(watcher_msg_t); diff --git a/tt_metal/llrt/blackhole/bh_hal_tensix.cpp b/tt_metal/llrt/blackhole/bh_hal_tensix.cpp index eb17f10bf112..b85f3214bbfd 100644 --- a/tt_metal/llrt/blackhole/bh_hal_tensix.cpp +++ b/tt_metal/llrt/blackhole/bh_hal_tensix.cpp @@ -32,7 +32,6 @@ HalCoreInfoType create_tensix_mem_map() { mem_map_bases.resize(static_cast(HalL1MemAddrType::COUNT)); mem_map_bases[static_cast(HalL1MemAddrType::BASE)] = MEM_L1_BASE; - mem_map_bases[static_cast(HalL1MemAddrType::BARRIER)] = MEM_L1_BARRIER; mem_map_bases[static_cast(HalL1MemAddrType::MAILBOX)] = MEM_MAILBOX_BASE; mem_map_bases[static_cast(HalL1MemAddrType::LAUNCH)] = GET_MAILBOX_ADDRESS_HOST(launch); mem_map_bases[static_cast(HalL1MemAddrType::WATCHER)] = GET_MAILBOX_ADDRESS_HOST(watcher); @@ -51,7 +50,6 @@ HalCoreInfoType create_tensix_mem_map() { std::vector mem_map_sizes; mem_map_sizes.resize(static_cast(HalL1MemAddrType::COUNT)); mem_map_sizes[static_cast(HalL1MemAddrType::BASE)] = MEM_L1_SIZE; - mem_map_sizes[static_cast(HalL1MemAddrType::BARRIER)] = sizeof(uint32_t); mem_map_sizes[static_cast(HalL1MemAddrType::MAILBOX)] = MEM_MAILBOX_SIZE; mem_map_sizes[static_cast(HalL1MemAddrType::LAUNCH)] = sizeof(launch_msg_t); mem_map_sizes[static_cast(HalL1MemAddrType::WATCHER)] = sizeof(watcher_msg_t); diff --git a/tt_metal/llrt/grayskull/gs_hal.cpp b/tt_metal/llrt/grayskull/gs_hal.cpp index 03bb4e0c84e0..cb51d98637d9 100644 --- a/tt_metal/llrt/grayskull/gs_hal.cpp +++ b/tt_metal/llrt/grayskull/gs_hal.cpp @@ -45,7 +45,6 @@ void Hal::initialize_gs() { mem_map_bases.resize(static_cast(HalL1MemAddrType::COUNT)); mem_map_bases[static_cast(HalL1MemAddrType::BASE)] = MEM_L1_BASE; - mem_map_bases[static_cast(HalL1MemAddrType::BARRIER)] = MEM_L1_BARRIER; mem_map_bases[static_cast(HalL1MemAddrType::MAILBOX)] = MEM_MAILBOX_BASE; mem_map_bases[static_cast(HalL1MemAddrType::LAUNCH)] = GET_MAILBOX_ADDRESS_HOST(launch); mem_map_bases[static_cast(HalL1MemAddrType::WATCHER)] = GET_MAILBOX_ADDRESS_HOST(watcher); @@ -66,7 +65,6 @@ void Hal::initialize_gs() { std::vector mem_map_sizes; mem_map_sizes.resize(static_cast(HalL1MemAddrType::COUNT)); mem_map_sizes[static_cast(HalL1MemAddrType::BASE)] = MEM_L1_SIZE; - mem_map_sizes[static_cast(HalL1MemAddrType::BARRIER)] = sizeof(uint32_t); mem_map_sizes[static_cast(HalL1MemAddrType::MAILBOX)] = MEM_MAILBOX_SIZE; mem_map_sizes[static_cast(HalL1MemAddrType::LAUNCH)] = sizeof(launch_msg_t); mem_map_sizes[static_cast(HalL1MemAddrType::WATCHER)] = sizeof(watcher_msg_t); diff --git a/tt_metal/llrt/hal.hpp b/tt_metal/llrt/hal.hpp index 9344b6bd4ac5..46dc1bbb4c24 100644 --- a/tt_metal/llrt/hal.hpp +++ b/tt_metal/llrt/hal.hpp @@ -38,7 +38,6 @@ enum class HalProcessorClassType : uint8_t { enum class HalL1MemAddrType : uint8_t { BASE, - BARRIER, MAILBOX, LAUNCH, WATCHER, @@ -52,7 +51,7 @@ enum class HalL1MemAddrType : uint8_t { FW_VERSION_ADDR, // Really only applicable to active eth core right now LOCAL, BANK_TO_NOC_SCRATCH, - COUNT // Keep this last so it always indicates number of enum options + COUNT // Keep this last so it always indicates number of enum options }; enum class HalDramMemAddrType : uint8_t { DRAM_BARRIER = 0, COUNT = 1 }; diff --git a/tt_metal/llrt/tt_cluster.cpp b/tt_metal/llrt/tt_cluster.cpp index bf056fd446a6..ee3ca9b27b56 100644 --- a/tt_metal/llrt/tt_cluster.cpp +++ b/tt_metal/llrt/tt_cluster.cpp @@ -252,15 +252,6 @@ void Cluster::open_driver(const bool &skip_driver_allocs) { } else if (this->target_type_ == TargetDevice::Simulator) { device_driver = std::make_unique(sdesc_path); } - std::uint32_t dram_barrier_base = tt_metal::hal.get_dev_addr(tt_metal::HalDramMemAddrType::DRAM_BARRIER); - device_driver->set_device_dram_address_params(tt_device_dram_address_params{dram_barrier_base}); - - l1_address_params.tensix_l1_barrier_base = tt_metal::hal.get_dev_addr(tt_metal::HalProgrammableCoreType::TENSIX, tt_metal::HalL1MemAddrType::BARRIER); - if (tt_metal::hal.get_arch() != tt::ARCH::GRAYSKULL) { - l1_address_params.eth_l1_barrier_base = tt_metal::hal.get_dev_addr(tt_metal::HalProgrammableCoreType::ACTIVE_ETH, tt_metal::HalL1MemAddrType::BARRIER); - l1_address_params.fw_version_addr = tt_metal::hal.get_dev_addr(tt_metal::HalProgrammableCoreType::ACTIVE_ETH, tt_metal::HalL1MemAddrType::FW_VERSION_ADDR); - } - device_driver->set_device_l1_address_params(l1_address_params); this->get_metal_desc_from_tt_desc( device_driver->get_virtual_soc_descriptors(), device_driver->get_harvesting_masks_for_soc_descriptors()); diff --git a/tt_metal/llrt/wormhole/wh_hal_active_eth.cpp b/tt_metal/llrt/wormhole/wh_hal_active_eth.cpp index c0af4cc0bd72..c79c146dafff 100644 --- a/tt_metal/llrt/wormhole/wh_hal_active_eth.cpp +++ b/tt_metal/llrt/wormhole/wh_hal_active_eth.cpp @@ -26,7 +26,6 @@ HalCoreInfoType create_active_eth_mem_map() { mem_map_bases.resize(static_cast(HalL1MemAddrType::COUNT)); mem_map_bases[static_cast(HalL1MemAddrType::BASE)] = 0x0; // Anything better to use? - mem_map_bases[static_cast(HalL1MemAddrType::BARRIER)] = eth_l1_mem::address_map::ERISC_BARRIER_BASE; mem_map_bases[static_cast(HalL1MemAddrType::MAILBOX)] = eth_l1_mem::address_map::ERISC_MEM_MAILBOX_BASE; mem_map_bases[static_cast(HalL1MemAddrType::LAUNCH)] = GET_ETH_MAILBOX_ADDRESS_HOST(launch); @@ -41,8 +40,6 @@ HalCoreInfoType create_active_eth_mem_map() { mem_map_bases[static_cast(HalL1MemAddrType::GO_MSG)] = GET_ETH_MAILBOX_ADDRESS_HOST(go_message); mem_map_bases[static_cast(HalL1MemAddrType::LAUNCH_MSG_BUFFER_RD_PTR)] = GET_ETH_MAILBOX_ADDRESS_HOST(launch_msg_rd_ptr); - mem_map_bases[static_cast(HalL1MemAddrType::FW_VERSION_ADDR)] = - eth_l1_mem::address_map::FW_VERSION_ADDR; mem_map_bases[static_cast(HalL1MemAddrType::BANK_TO_NOC_SCRATCH)] = eth_l1_mem::address_map::ERISC_MEM_BANK_TO_NOC_SCRATCH; @@ -50,7 +47,6 @@ HalCoreInfoType create_active_eth_mem_map() { mem_map_sizes.resize(static_cast(HalL1MemAddrType::COUNT)); mem_map_sizes[static_cast(HalL1MemAddrType::BASE)] = eth_l1_mem::address_map::MAX_SIZE; // Anything better to use? - mem_map_sizes[static_cast(HalL1MemAddrType::BARRIER)] = eth_l1_mem::address_map::ERISC_BARRIER_SIZE; mem_map_sizes[static_cast(HalL1MemAddrType::MAILBOX)] = eth_l1_mem::address_map::ERISC_MEM_MAILBOX_SIZE; mem_map_sizes[static_cast(HalL1MemAddrType::LAUNCH)] = sizeof(launch_msg_t); @@ -63,7 +59,6 @@ HalCoreInfoType create_active_eth_mem_map() { eth_l1_mem::address_map::MAX_SIZE - eth_l1_mem::address_map::ERISC_L1_UNRESERVED_BASE; mem_map_sizes[static_cast(HalL1MemAddrType::GO_MSG)] = sizeof(go_msg_t); mem_map_sizes[static_cast(HalL1MemAddrType::LAUNCH_MSG_BUFFER_RD_PTR)] = sizeof(uint32_t); - mem_map_sizes[static_cast(HalL1MemAddrType::FW_VERSION_ADDR)] = sizeof(std::uint32_t); mem_map_sizes[static_cast(HalL1MemAddrType::BANK_TO_NOC_SCRATCH)] = eth_l1_mem::address_map::ERISC_MEM_BANK_TO_NOC_SIZE; std::vector> processor_classes(NumEthDispatchClasses); diff --git a/tt_metal/llrt/wormhole/wh_hal_idle_eth.cpp b/tt_metal/llrt/wormhole/wh_hal_idle_eth.cpp index 6a5b617a3d25..4fbead7a185d 100644 --- a/tt_metal/llrt/wormhole/wh_hal_idle_eth.cpp +++ b/tt_metal/llrt/wormhole/wh_hal_idle_eth.cpp @@ -36,7 +36,6 @@ HalCoreInfoType create_idle_eth_mem_map() { mem_map_bases.resize(static_cast(HalL1MemAddrType::COUNT)); mem_map_bases[static_cast(HalL1MemAddrType::BASE)] = MEM_ETH_BASE; - mem_map_bases[static_cast(HalL1MemAddrType::BARRIER)] = MEM_L1_BARRIER; mem_map_bases[static_cast(HalL1MemAddrType::MAILBOX)] = MEM_IERISC_MAILBOX_BASE; mem_map_bases[static_cast(HalL1MemAddrType::LAUNCH)] = GET_IERISC_MAILBOX_ADDRESS_HOST(launch); mem_map_bases[static_cast(HalL1MemAddrType::WATCHER)] = GET_IERISC_MAILBOX_ADDRESS_HOST(watcher); @@ -54,7 +53,6 @@ HalCoreInfoType create_idle_eth_mem_map() { std::vector mem_map_sizes; mem_map_sizes.resize(static_cast(HalL1MemAddrType::COUNT)); mem_map_sizes[static_cast(HalL1MemAddrType::BASE)] = MEM_ETH_SIZE; - mem_map_sizes[static_cast(HalL1MemAddrType::BARRIER)] = sizeof(std::uint32_t); mem_map_sizes[static_cast(HalL1MemAddrType::MAILBOX)] = MEM_IERISC_MAILBOX_SIZE; mem_map_sizes[static_cast(HalL1MemAddrType::LAUNCH)] = sizeof(launch_msg_t); mem_map_sizes[static_cast(HalL1MemAddrType::WATCHER)] = sizeof(watcher_msg_t); diff --git a/tt_metal/llrt/wormhole/wh_hal_tensix.cpp b/tt_metal/llrt/wormhole/wh_hal_tensix.cpp index e4d6c42981e6..d313d3b31961 100644 --- a/tt_metal/llrt/wormhole/wh_hal_tensix.cpp +++ b/tt_metal/llrt/wormhole/wh_hal_tensix.cpp @@ -33,7 +33,6 @@ HalCoreInfoType create_tensix_mem_map() { mem_map_bases.resize(static_cast(HalL1MemAddrType::COUNT)); mem_map_bases[static_cast(HalL1MemAddrType::BASE)] = MEM_L1_BASE; - mem_map_bases[static_cast(HalL1MemAddrType::BARRIER)] = MEM_L1_BARRIER; mem_map_bases[static_cast(HalL1MemAddrType::MAILBOX)] = MEM_MAILBOX_BASE; mem_map_bases[static_cast(HalL1MemAddrType::LAUNCH)] = GET_MAILBOX_ADDRESS_HOST(launch); mem_map_bases[static_cast(HalL1MemAddrType::WATCHER)] = GET_MAILBOX_ADDRESS_HOST(watcher); @@ -52,7 +51,6 @@ HalCoreInfoType create_tensix_mem_map() { std::vector mem_map_sizes; mem_map_sizes.resize(static_cast(HalL1MemAddrType::COUNT)); mem_map_sizes[static_cast(HalL1MemAddrType::BASE)] = MEM_L1_SIZE; - mem_map_sizes[static_cast(HalL1MemAddrType::BARRIER)] = sizeof(std::uint32_t); mem_map_sizes[static_cast(HalL1MemAddrType::MAILBOX)] = MEM_MAILBOX_SIZE; mem_map_sizes[static_cast(HalL1MemAddrType::LAUNCH)] = sizeof(launch_msg_t); mem_map_sizes[static_cast(HalL1MemAddrType::WATCHER)] = sizeof(watcher_msg_t); diff --git a/tt_metal/third_party/umd b/tt_metal/third_party/umd index e92ac1c44eab..0ddab7810664 160000 --- a/tt_metal/third_party/umd +++ b/tt_metal/third_party/umd @@ -1 +1 @@ -Subproject commit e92ac1c44eab7a1bd06e6da321fa9309e5a73159 +Subproject commit 0ddab7810664ffa8617d81b9bd6ce7330c28f6cb