Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning OpType not found in params. Defaulting to nop params. for OpTypes sine, cosine, and abs #35

Closed
mvkvc opened this issue Jul 21, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@mvkvc
Copy link

mvkvc commented Jul 21, 2024

When working to add the Phi-3 model to tt-buda-demos in this PR I received these warnings in my pipeline which seem to be impacting the results. This is for a torch model using transformers running on a Grayskull e75 on Ubuntu 20.04. The full code along with the system information can be found in that PR.

Here are the different related warnings shown:

  • 2024-07-21 17:48:48.253 | WARNING | Model - OpType 'abs' not found in params. Defaulting to nop params.
  • 2024-07-21 17:48:41.827 | WARNING | Model - OpType 'cosine' not found in params. Defaulting to nop params.
  • 2024-07-21 17:48:41.827 | WARNING | Model - OpType 'sine' not found in params. Defaulting to nop params.

Any guidance on how to resolve would be appreciated.

@milank94 milank94 added the enhancement New feature or request label Jul 22, 2024
@mvkvc
Copy link
Author

mvkvc commented Jul 24, 2024

I learned that the balancer performance estimation parameters for those ops here don't exist for Grayskull. The model does take very long to balance so this makes sense. If this is expected behaviour and doesn't affect the model output after compilation I can close.

@staylorTT
Copy link
Contributor

@tt-mpantic Please investigate where in the stack these are being raised and if any action needs to be taken.

@tt-mpantic
Copy link
Contributor

tt-mpantic commented Aug 1, 2024

Hi @mvkvc,

As you already correctly noted performance estimation parameters are not provided for these ops, hence the warning. Absence of these parameters can affect how BUDA compiler balances and places operations on the chip but it doesn't affect model output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants