Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Documentation Structure #21

Open
dongsam opened this issue Jul 21, 2021 · 1 comment
Open

Admin: Documentation Structure #21

dongsam opened this issue Jul 21, 2021 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation Epic

Comments

@dongsam
Copy link
Contributor

dongsam commented Jul 21, 2021

Apply a better documentation structure by referring to cosmos-cash before the production level release.

But currently, the farming module spec is frequently changed, so we are prototyping to the PoC level, therefore we plan to write detailed documentation of How-To and Tutorials after the alpha version.

A basic document format or spec doc can be applied in advance, regardless of the direction of the code.

In addition, for quick decision-making and development, the initial Spec will be applied to the Spec without the ADR process, and major changes need to be discussed or decisions after the release will be subject to the ADR process.

/
├── README
├── CONTRIBUTING
├── TECHNICAL-SETUP
├── CODEOWNERS
├── x/
|   ├── module_a/
|       ├── README
|       ├── docs/
|           ├── state
|           ├── state_transitions
|           ├── messages
├── docs/
    ├── README
    ├── CODEOWNERS
    ├── Explanation/
    |   ├── README
    |   ├── ADR/
    |   |   ├── README
    |   |   ├── PROCESS
    |   |   ├── adr-template
    |   |   ├── adr-{number}-{desc}
    |   ├── articles/
    |   |   ├── regulation-litepaper/
    |   |       ├── ARTICLE
    |   ├── research/
    |       ├── README
    |       ├── research_topic/
    ├── How-To/
    |   ├── HowToDoSomething/
    |   ├── HowToDoSomethingElse/
    ├── Reference/
    |   ├── README
    |   ├── GLOSSARY
    |   ├── MODULES
    |   ├── use-cases/
    |   |   ├── use-case-A
    |   |   ├── use-case-B
    |   ├── architecture/
    ├── Tutorials/
        ├── Tutorial_1/
        ├── Tutorial_2/

Ref.

@dongsam dongsam added the documentation Improvements or additions to documentation label Jul 21, 2021
@dongsam dongsam added this to the v1 milestone Jul 27, 2021
jaybxyz added a commit to jaybxyz/farming that referenced this issue Jul 28, 2021
dongsam pushed a commit that referenced this issue Aug 2, 2021
* add proposal proto for public proposal plan messages

* update proto files

* temp

* change method name to prevent from duplicate

* WIP: designing what args to accept for adding plan proposal...

* change binary name to farmingd

* change proposal design
- update proposal proto messages

* add private plans and public plans are work in progress

* update cli commands for private plans

* add tests for private farming plan command line interfaces

* add public plan proposal

* add nolint:errcheck for now

* fix golint by adding return value for sdkerrors.Wrapf

* add name filed in both create fixed amount plan and ratio plan messages

* apply feedback

* add validation and fix public ratio plan creation logic

* remove empty name field and use the one from the passed argument

* remove unused rest code

* move the name field inside the AddRequestProposal

* add description on PublicPlanProposal message

* fix typo and add 09_proposal.md

* add name field in update plan proposal

* make indentation consistent and change variable name

* reformat json

* fix broken app

* use three ifs instead of switch case and use else if to prevent from creating more than one plan type

* add detailed validation logics for AddRequestProposal, UpdateRequestProposal, DeleteRequestProposal

* re: add detailed validation logics for AddRequestProposal, UpdateRequestProposal, DeleteRequestProposal

* add skeleton for docs #21

* add How-To farming_plans.md

* update comment

* add validation for duplicate plan name

* update date time format to RFC3339

* feat: update public plan proposal

* feat: adding validation logic for an epoch ratio must not exceed 1 with the same account

* feat: add validation logic for overflow epoch ratio

* fix: add another if statement to check when both epoch amount and ratio are provided

* chore: update public plan proposal logics
- add validation logic for ratio plans
- add test codes for the validation
- clean up error messages

* docs: add command-line interfaces and update context
@minkyraccoon minkyraccoon changed the title Apply better Documentation Structure Admin: Documentation Structure Sep 13, 2021
@minkyraccoon
Copy link

Comment: ADR's SHOULD NOT be optional. If a POC is built then a decision must have been made and documented. The purpose of the ADR is to describe the architecture and get feedback on it. ADR's can be used to do this.
Likewise, if you discover that the PoC has an issue and needs a new implementation (e.g. F1) then this can be raised in a new ADR. Now we have a record next to the code of why the module has been implemented the way it is.
The advantage now is that instead of having to explain the design every time, people can find and read the documentation for themselves.

@dongsam dongsam removed this from the Farming F1 v1.0 milestone Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Epic
Projects
None yet
Development

No branches or pull requests

4 participants