-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin: Documentation Structure #21
Comments
* add proposal proto for public proposal plan messages * update proto files * temp * change method name to prevent from duplicate * WIP: designing what args to accept for adding plan proposal... * change binary name to farmingd * change proposal design - update proposal proto messages * add private plans and public plans are work in progress * update cli commands for private plans * add tests for private farming plan command line interfaces * add public plan proposal * add nolint:errcheck for now * fix golint by adding return value for sdkerrors.Wrapf * add name filed in both create fixed amount plan and ratio plan messages * apply feedback * add validation and fix public ratio plan creation logic * remove empty name field and use the one from the passed argument * remove unused rest code * move the name field inside the AddRequestProposal * add description on PublicPlanProposal message * fix typo and add 09_proposal.md * add name field in update plan proposal * make indentation consistent and change variable name * reformat json * fix broken app * use three ifs instead of switch case and use else if to prevent from creating more than one plan type * add detailed validation logics for AddRequestProposal, UpdateRequestProposal, DeleteRequestProposal * re: add detailed validation logics for AddRequestProposal, UpdateRequestProposal, DeleteRequestProposal * add skeleton for docs #21 * add How-To farming_plans.md * update comment * add validation for duplicate plan name * update date time format to RFC3339 * feat: update public plan proposal * feat: adding validation logic for an epoch ratio must not exceed 1 with the same account * feat: add validation logic for overflow epoch ratio * fix: add another if statement to check when both epoch amount and ratio are provided * chore: update public plan proposal logics - add validation logic for ratio plans - add test codes for the validation - clean up error messages * docs: add command-line interfaces and update context
Comment: ADR's SHOULD NOT be optional. If a POC is built then a decision must have been made and documented. The purpose of the ADR is to describe the architecture and get feedback on it. ADR's can be used to do this. |
Apply a better documentation structure by referring to cosmos-cash before the production level release.
But currently, the farming module spec is frequently changed, so we are prototyping to the PoC level, therefore we plan to write detailed documentation of How-To and Tutorials after the alpha version.
A basic document format or spec doc can be applied in advance, regardless of the direction of the code.
In addition, for quick decision-making and development, the initial Spec will be applied to the Spec without the ADR process, and major changes need to be discussed or decisions after the release will be subject to the ADR process.
Ref.
The text was updated successfully, but these errors were encountered: