Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Update user resource to accept the new finadmin and account owner roles #132

Closed
jlacefie opened this issue Sep 29, 2024 · 5 comments · Fixed by #135
Closed

[Bug] Update user resource to accept the new finadmin and account owner roles #132

jlacefie opened this issue Sep 29, 2024 · 5 comments · Fixed by #135
Labels
bug Something isn't working

Comments

@jlacefie
Copy link
Collaborator

What are you really trying to do?

Temporal introduced 2 new roles: Account Owner and Finance Admin. The Terraform User Resource currently only supports admin, dev, read. This is a request to update the resource to accept the new role types.

Minimal Reproduction

To reproduce, create a .tf file with a user who has either account owner or finance admin for account access. Terraform plan will fail with

Attribute account_access value must be one of: ["admin" "developer" "read"], got: "Owner"

@jlacefie jlacefie added the bug Something isn't working label Sep 29, 2024
@jlacefie
Copy link
Collaborator Author

Note - Account Owner can only be assigned by Temporal. Adding it as an acceptable value may not make sense.

@wangzhihao0629
Copy link

Adding it as an acceptable value may not make sense.

Import might make sense. Ideally, we want to keep all the information in the format of codes including Account Owner. In this case, I'm okay with not being able to apply.

@jroof88
Copy link
Contributor

jroof88 commented Oct 3, 2024

@jlacefie This is breaking our terraform setup. I was going to put together a PR for owner to to be added to the values for account_access but before I do...will it be accepted?

@captainbeardo
Copy link

Owner does make sense as a value on an imported user, but not for a user being created through terraform. A PR would be welcome and we are actively watching PRs on this repo and will work with you to get it in.

@jroof88
Copy link
Contributor

jroof88 commented Oct 4, 2024

@captainbeardo That feels kind of backwards to me. For example, in the future let's say I want to transfer Account Owner to someone else on my team. I would have to file a support ticket with Temporal to change it and then import the user back into my tfstate? It would then still be broken cause my tf files would still say admin?

PR: #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants