From 55c4d36f84a75e61bee8216dafdaf49d7fd9e2e4 Mon Sep 17 00:00:00 2001 From: Haifeng He Date: Mon, 24 Jul 2023 11:17:36 -0700 Subject: [PATCH] Restore defaultListWorkflowsPageSize back to 1000 (from 100) (#4674) **What changed?** **Why?** GenerateReplicationTasks and VerifyReplicationTasks runs in parallel. VerifyReplicationTasks runs every 2s. Verification is not instantaneous, which means for every batch, Verification can delay at least 5s. Increase batch size, reduce the ration of the delay in batch processing. Before the change, RPS for GenerateReplicationTasks + VerifyReplicationTasks is 30 RPS. With the change RPS is 90. **How did you test it?** Cluster test. **Potential risks** **Is hotfix candidate?** Yes. --- service/worker/migration/force_replication_workflow.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/service/worker/migration/force_replication_workflow.go b/service/worker/migration/force_replication_workflow.go index 34f5ff96b6d..6f50234771c 100644 --- a/service/worker/migration/force_replication_workflow.go +++ b/service/worker/migration/force_replication_workflow.go @@ -133,7 +133,7 @@ const ( taskQueueUserDataReplicationDoneSignalType = "task-queue-user-data-replication-done" taskQueueUserDataReplicationVersionMarker = "replicate-task-queue-user-data" - defaultListWorkflowsPageSize = 100 + defaultListWorkflowsPageSize = 1000 defaultPageCountPerExecution = 200 maxPageCountPerExecution = 1000 defaultPageSizeForTaskQueueUserDataReplication = 20