Add workflow.instance() API for obtaining current workflow instance #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
720-workflow-instance
branch
2 times, most recently
from
2485f19 to
5d752a6
Compare
cretz
approved these changes
Jan 21, 2025
|
|
||
|
|
||
| class WorkflowInstanceAccessInboundInterceptor(WorkflowInboundInterceptor): | ||
| async def execute_workflow(self, input: ExecuteWorkflowInput) -> int: |
There was a problem hiding this comment.
Can you confirm that the workflow.instance() is non-None when this interceptor starts? I read through the code and I suspect it is, just wanted to confirm.
There was a problem hiding this comment.
Does this do what you're suggesting? 0b8a0bd
|
What about the activity instance? Will that be a separate issue? |
For activity instance, it's not needed in Python because we don't ever create the instance, only the user does. And we only need to provide the instance in cases where we create it and control the lifetime. |
dandavison
force-pushed
the
720-workflow-instance
branch
from
5d752a6 to
306b050
Compare
dandavison
force-pushed
the
720-workflow-instance
branch
from
306b050 to
49be3d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #720